Repository navigation
Mac: fix Metal HUD menu hide/show - #692
Closed
thehobbit85 wants to merge 1 commit into
Closed
thehobbit85 wants to merge 1 commit into
thehobbit85 wants to merge 1 commit into
Conversation
thehobbit85
force-pushed
the
codex/fix-metal-hud-menu
branch
from
October 30, 2026 14:46
fc6d976 to
e8389cc
Compare
thehobbit85
force-pushed
the
codex/fix-metal-hud-menu
branch
11 times, most recently
from
November 1, 2026 04:14
b31787e to
45829e1
Compare
thehobbit85
force-pushed
the
codex/fix-metal-hud-menu
branch
from
November 1, 2026 06:22
45829e1 to
27c5a58
Compare
seedds
added a commit
that referenced
this pull request
Nov 1, 2026
With DM_METAL_HUD=1, front_hud_env already sets MTL_HUD_ENABLED before the first Metal device. The game layer also set developerHUDProperties to mode=default, which forces that layer's HUD on: Apple's Hide HUD menu changed its label but left the overlay on screen. The layer's HUD properties now stay unset, so the menu hides and shows it. Co-authored-by: Eliran Zach <4012041+thehobbit85@users.noreply.github.com>
Owner
|
Landed as 8482873, with you as co-author. The |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
DM_METAL_HUD=1, the Mac layer forcesdeveloperHUDPropertiestomode=default, so Apple's Hide HUD action changes the menu label while leaving the overlay visible. Remove that forced layer mode and retainfront_hud_env's earlyMTL_HUD_ENABLEDinitialization; Apple's menu can then hide and restore the overlay. Existing menus, cheats and iOS behavior are preserved. #376 separately carries the build's HUD preference into a Mac app.Current integration and validation
Rebased onto pinned main
c1df4ddaaedc3c18228065ea5b909688b79884e2; head27c5a58950968b9eef3cd04650a2406ba126c328. The same existing PR remote branch and its canonical local tracking branch are retained. All paginated issue comments, reviews and inline feedback were read; no new feedback was found.Main's generic HID and pointer-hiding functions coexist with this separate layer-HUD initialization change. The screen/fullscreen callbacks and input lifecycle remain intact; main still has the forced HUD mode removed by this PR.
front_mac.msyntax compilation passed with the repository's ARC/deployment/profile flags and local macOS SDK, including the new HID/cursor code. It reports one existing unused-but-setactivityvariable warning.Range-diff marks the feature patch unchanged, and the old-to-new tree delta exactly matches the upstream increment. Ancestry and
git diff --checkpass. The previous d138-based head45829e1b409fb3242c64fa91492c509a04ece280completed all 7 CI checks successfully; that is historical evidence. CI for this new head is pending. Central shared validation passed on4820ba509adb90ee7cca8c5a65a51e0a4dc12e74withGAME=010015100B514000:t_fs(102 checks),t_fs_case(51),t_fs_commit_list(98),t_nfc(54),t_pad_hid(19), andt_system_event. Their production/fixture sources, host headers, profile inputs, build flags and target recipes were verified identical to this head. This is shared fixture coverage, not a full host build or full graphics run of this PR.Local native tools are Xcode 27.0/Metal 32023.921; supported Xcode 27.2/Metal 32023.922 verification belongs to the new CI run. No gameplay, physical-display timing or interactive HUD check, extraction rebuild, device installation, game shader rebuild, or fresh game shader/interface comparison was performed. Earlier full-suite/game evidence remains historical at its recorded revisions.