Repository navigation
Restore the Metal HUD option in Mac app builds - #376
Open
thehobbit85 wants to merge 2 commits into
Open
thehobbit85 wants to merge 2 commits into
thehobbit85 wants to merge 2 commits into
Conversation
5 of 12 tasks
Contributor
|
Heads-up: seedds asked in #388 to agree on one settings schema and one store for player choices before the launchers are extended. I posted a proposal there (#388 (comment)): one optional |
thehobbit85
force-pushed
the
codex/mac-bundle-show-fps
branch
4 times, most recently
from
October 30, 2026 17:11
8403c87 to
0cd5804
Compare
thehobbit85
force-pushed
the
codex/mac-bundle-show-fps
branch
16 times, most recently
from
November 2, 2026 15:48
77bd45d to
be51bc2
Compare
thehobbit85
force-pushed
the
codex/mac-bundle-show-fps
branch
from
November 2, 2026 17:43
be51bc2 to
4c7d8ad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mac app packaging returns before the iOS-only
SHOW_FPSresolution, so--show-fpsnever reaches the Mac host. Carry the resolved choice throughDMShowFPSin the bundle to the startupDM_METAL_HUDdefault and the existing launcher HUD setting.--no-show-fpsdisables that build default; changing the choice invalidates bundle reuse. Process/environment-file values and saved/window choices retain their precedence.The existing shared settings schema and choice store satisfy the settings-schema feedback. Main's runtime HUD-menu fix remains separate from this missing build/startup preference. The documentation explains the option and retains the open visual-validation limit; main's content-based archive key and shader-extraction reuse behavior are preserved.
Revision
4c7d8ad681d30d5791ceba04914e89e2917fd80cincludes main65501fbbaf8526f7aab0a1edd028135888590f8e. Packaged Mac apps still lack the launcher option for the Metal HUD.Validation on
4c7d8ad681d3.python3 -m unittest dm.tools.tests.test_docs dm.tools.tests.test_settings dm.tools.tests.test_launcher_settings dm.tools.tests.test_nsp_progress dm.tools.tests.test_nsp_incremental— 101 tests passed.GitHub checks for this revision
Earlier local validation on
25b1a736ba8c.python3 -m unittest dm.tools.tests.test_docs dm.tools.tests.test_settings dm.tools.tests.test_launcher_settings dm.tools.tests.test_nsp_mac dm.tools.tests.test_nsp_incremental. All 99 tests passed.python3 -m unittest dm.tools.tests.test_nsp_mac_apppassed all 47 cases. The packaged Mac app fixture also exercised its launcher, preference storage and environment propagation. The user-facing overlay still needs visual confirmation in a running game.This affects every Mac app using the shared packer/launcher; Pokémon Legends: Z-A is the reported case. Synthetic app and settings fixtures exercise the preference/bundle/environment boundary directly, so no game was selected for a gameplay run. Visual confirmation of the overlay/menu in a running game remains open. No gameplay, extraction rebuild, game shader rebuild or device installation was performed.