feat: add bbknn - #4306
Open
Intron7 wants to merge 3 commits into
Open
Conversation
Signed-off-by: Intron7 <sdicks@nvidia.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4306 +/- ##
==========================================
+ Coverage 80.01% 80.14% +0.13%
==========================================
Files 132 133 +1
Lines 13397 13511 +114
==========================================
+ Hits 10719 10828 +109
- Misses 2678 2683 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
|
flying-sheep
left a comment
Member
There was a problem hiding this comment.
Looks great!
I deduplicated the transformer creation method and adapted the heuristic a bit, and added a benchmark suite to check it. Take a look if that makes sense or if I missed something!
The only piece I think is missing is that we should get rid of legacy cruft, but I can take care of that:
- no reason for
_accepts_legacy_random_state - things like
batch_keyand so on should become something acceptingAdRefs or strs in theresolveformat ("obs.obs_colname"instead of"obs_colname", and then_keyof course makes no sense).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR add a scanpy native bbknn implementation because of the removal of external
fixes #4302