Repository navigation
fix(output): avoid blank tee hint lines - #4166
Closed
Ha1baraA11 wants to merge 1 commit into
Closed
Ha1baraA11 wants to merge 1 commit into
Ha1baraA11 wants to merge 1 commit into
Conversation
Collaborator
|
Thanks for this fix. The empty-body case is now handled on develop by #4154 (merged 2026-10-09), which reworked emit_guarded so that with no filtered text the recovery hint is printed alone, without a blank line above it. Develop also carries a regression test for exactly this case (empty_body_with_hint_prints_the_hint_alone in src/core/runner.rs). If I missed something this PR covers, please comment or reopen. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
cargo fmt --all && cargo clippy --all-targets && cargo testrtk <command>output inspectedcargo fmt --all -- --check,cargo test --bin rtk, and Clippy pass.cargo test --testshas two existing develop-baseline Git-output assertion failures unrelated to this change.Fixes #4159