Repository navigation
fix: emit_guarded no longer prints leading blank line when filtered is empty (fixes #4159) - #4295
Closed
TechWizard9999 wants to merge 9 commits into
Closed
TechWizard9999 wants to merge 9 commits into
TechWizard9999 wants to merge 9 commits into
Conversation
…s empty Only insert the newline separator between body and hint when the filtered body is non-empty. Fixes rtk-ai#4159.
📊 Automated PR Analysis
SummaryFixes a formatting bug in emit_guarded where an empty filtered body followed by a tee hint produced a stray leading blank line. The fix skips the newline separator when the filtered body is empty and adds unit tests covering the empty, non-empty, and no-hint cases. Review Checklist
Linked issues: #4159 Analyzed automatically by wshm · This is an automated analysis, not a human review. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4159: was printing a stray leading blank line when the filtered body was empty and a tee hint followed.
Changes
Testing