Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,10 @@

<section class="rz-page__body">
{% embed '@RoadizRozier/includes/rz_table.html.twig' with {
sortable: {
enabled: true,
url: path('customFormFieldPositionAjax'),
},
actions_available: true,
}%}
{% block thead_cells %}
Expand All @@ -33,9 +37,9 @@
{% for field in fields %}
<tr
data-position="{{ field.position }}"
data-field-id="{{ field.getId }}"
data-id="{{ field.getId }}"
>
<td>
<td class="rz-table__handle">
{% import '@RoadizRozier/macros/rz_link.html.twig' as rz_link %}
{{ rz_link.root({
label: field.label,
Expand Down
10 changes: 1 addition & 9 deletions lib/Rozier/app/Lazyload.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import CustomFormFieldsPosition from '~/components/custom-form-fields/CustomFormFieldsPosition'
import StackNodeTree from '~/widgets/StackNodeTree'
import SettingsSaveButtons from '~/widgets/SettingsSaveButtons'
import NodeStatuses from '~/widgets/NodeStatuses'
Expand All @@ -22,7 +21,6 @@ export default class Lazyload {
linksSelector: HTMLAnchorElement[]
currentRequest: AbortController | null
currentTimeout: number | null
customFormFieldsPosition: Unbindable
settingsSaveButtons: Unbindable
jsonEditors: JsonEditor[]
cssEditors: CssEditor[]
Expand All @@ -34,7 +32,6 @@ export default class Lazyload {
this.linksSelector = []
this.currentRequest = null
this.currentTimeout = null
this.customFormFieldsPosition = null
this.settingsSaveButtons = null
this.jsonEditors = []
this.cssEditors = []
Expand Down Expand Up @@ -275,19 +272,14 @@ export default class Lazyload {
* General bind on page load
*/
generalBind() {
this.generalUnbind([
this.stackNodeTrees,
this.customFormFieldsPosition,
this.settingsSaveButtons,
])
this.generalUnbind([this.stackNodeTrees, this.settingsSaveButtons])
this.bindAjaxLink()
this.jsonEditors = []
this.cssEditors = []
this.yamlEditors = []

this.stackNodeTrees = new StackNodeTree()

this.customFormFieldsPosition = new CustomFormFieldsPosition()
this.settingsSaveButtons = new SettingsSaveButtons()

this.initJsonEditors()
Expand Down

This file was deleted.

6 changes: 3 additions & 3 deletions lib/Rozier/docs/ui-redesign-todo.md
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ build momentum; the heavily legacy zones need a real effort, not just touch-ups.
| 4 | Cross-cutting dialogs / overlays | 7/13 | Used by every other zone — the legacy duplicates (`RzButton.vue`/`RzTextarea.vue`) were removed as dead code in #534 |
| 5 | Explorer / Drawer | 6/9 | `NodeTypesDrawerContainer.vue`, the heaviest UIkit user, was dead and removed in #534; the remaining legacy files still need migrating |
| 6 | Tags / Folders | 1/6 | The biggest gap — probably not just catch-up work, needs a real design pass before coding |
| 7 | Custom forms | 0/1 | Small footprint but never started |
| 7 | Custom forms | 1/1 | Small footprint but never started; its only legacy script (`CustomFormFieldsPosition.js`) was replaced by the `RzTable` sortable in #537 |
| 8 | User management | 0 dedicated component | No existing foundation, the biggest remaining effort — to be scoped separately with a dedicated Figma mockup |

## Phase order
Expand Down Expand Up @@ -133,7 +133,7 @@ The dismissible alert is the one exception: it has no native equivalent and need
## Phase 6 — Remaining heavy zones

- [ ] Scope Tags/Folders with a real Figma design pass (not just code catch-up)
- [ ] Scope Custom forms (the v2.8 regression [#537](https://github.com/roadiz/core-bundle-dev-app/issues/537), lost drag-and-drop reordering of fields, is fixed beforehand as a regression)
- [ ] Scope Custom forms (the v2.8 regression [#537](https://github.com/roadiz/core-bundle-dev-app/issues/537), lost drag-and-drop reordering of fields, is fixed: the fields list uses the `rz_table` sortable option and `CustomFormFieldsPosition.js` is removed)
- [ ] Scope User management (no existing dedicated component — the biggest remaining effort)

## Phase 7 — New features
Expand Down Expand Up @@ -167,7 +167,7 @@ that would skew `git log -1`.
| Explorer/Drawer (related-entity picker) | 9 | 6 | 3 (incl. `NodeTypesDrawerContainer.vue`, still heavily UIkit despite being touched by the squash commit; removed as dead code in #534) | 2/9 |
| Tags/Folders | 6 | 1 | 5 | 0/6 |
| Login/search | 2 | 1 | 1 | 2/2 |
| Custom forms | 1 | 0 | 1 | 0/1 |
| Custom forms (fields reordering, via `RzTable`) | 1 | 1 | 0 | 0/1 |
| User management | 0 dedicated component (Symfony/Twig + legacy `assets/less/users/`) | — | — | — |

**Quantified technical debt** (scope of [ADR 0001](adr/0001-custom-elements-over-vue-uikit-jquery.md)):
Expand Down
Loading