Repository navigation
fix(rozier): restore custom-form fields reordering - #556
Merged
Merged
Conversation
added 2 commits
October 30, 2026 14:41
Enable the rz_table sortable option on the custom-form fields list, posting to customFormFieldPositionAjax, as on node attributes. Rows now carry data-id and a rz-table__handle cell. Remove CustomFormFieldsPosition.js and its Lazyload wiring: it listened to UIkit sortable markup no template renders since #279. Closes #537
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
v2.8 regression: the custom-form fields list could no longer be reordered by drag-and-drop. The fix wires the
rz_tablesortable option, as on node attributes, and removes the dead UIkit-based script.rz-tablealready postsid+prevId/nextId+ CSRF token, which is thePositionDtopayloadcustomFormFieldPositionAjaxexpects: no PHP change.Closes #537
Evidence
data-sortableon the table).After (dev app, custom form New Crowdin updates #2 with 3 fields):
Not covered by a real drag: the drop at the last position (same
prevIdpath as the middle drop) and the missingROLE_ACCESS_CUSTOMFORMS_DELETEcase (same error path as the invalid token). Checked in dark theme only.Merge Danger
Door: two-way
Blast Radius: small
Only the custom-form fields list.
window.RozierConfig.routes.customFormFieldPositionAjaxis kept inbase.html.twigin case a third-party script reads it. Follow-up: UIkitsortable(JS inmain.js, CSS invendor.less) now has no JS consumer left and can be removed.