fix: fail CI on test timeout and upload vitest report on failure (closes #706)#853
fix: fail CI on test timeout and upload vitest report on failure (closes #706)#853boalambo wants to merge 6 commits into
Conversation
|
@boalambo Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
|
Gm maintainer, looking forward to hearing from you. |
Resolves conflicts in: - src/app/api/auth/login/route.ts - src/app/api/performance/vitals/route.ts - src/app/components/dashboard/DashboardGrid.tsx - src/app/hooks/useDashboardWidgets.tsx - src/components/CommandPalette.tsx - src/store/synchronizationEngine.ts All conflicts resolved by accepting upstream/main's fixes from rinafcode#836 (orphaned merge-conflict artifacts) plus reconciling missing imports.
|
Merge conflicts from #836 are resolved and pushed (build, Type Check/Lint/Validation, and the quality gate are all green ✅). |
Problem
The test step in
.github/workflows/ci.ymlwrappedvitest runin ashell timeout with
|| exit 0. This caused the CI job to always exitwith code 0 — even when tests failed or the suite timed out — giving
false confidence and allowing broken builds to be merged undetected.
Changes
|| exit 0fallback and the shelltimeoutwrappertimeout-minutes: 5directly on theRun Testsstep soGitHub Actions enforces the limit and fails the job on expiry
--reporter=json --outputFile=vitest-report.jsonto Vitestso a structured report is written during the run
Upload test report on failurestep that uploadsvitest-report.jsonas a CI artifact when the job failsAcceptance Criteria
Impacted Files
.github/workflows/ci.ymlCloses #706