fix: replace console.* calls with structured logging service#836
Conversation
|
@boalambo Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
|
Type-check errors are now resolved. The remaining test failures |
|
Great job so far There’s just one blocker — workflow. Could you take a look and resolve it? Happy to review again once that’s done. |
blocker is resolved and ready for re-review. |
Fixes duplicate/dangling code left behind by prior merges with main: - CommandPalette.tsx: removed orphaned placeholder onCreate prop - DashboardGrid.tsx: removed orphaned useEffect fragment calling undefined saveWidgetLayout - useDashboardWidgets.tsx: removed duplicate React import Root cause of the recurring Type Check CI failures.
…lure AsyncLocalStorage from node:async_hooks was statically imported, causing webpack to fail bundling it into client components (e.g. error.tsx) that import the logger. Now dynamically required and guarded behind a server-only check so it's excluded from client bundles.
|
Please check for approval again |
|
Thank you for contributing to the project. Your other task that you removed the CI, Kindly add it here so that i can close both together. |
|
Closes #706 |
Thank for always supporting and the guidelines. So much appreciated. I finally fix it all 💃 |
|
Looking forward to working with you in the next wave ma. |
Resolves conflicts in: - src/app/api/auth/login/route.ts - src/app/api/performance/vitals/route.ts - src/app/components/dashboard/DashboardGrid.tsx - src/app/hooks/useDashboardWidgets.tsx - src/components/CommandPalette.tsx - src/store/synchronizationEngine.ts All conflicts resolved by accepting upstream/main's fixes from rinafcode#836 (orphaned merge-conflict artifacts) plus reconciling missing imports.
2 participants
Closes #753
Changes
Acceptance Criteria Met