Skip to content

List the pull request's changelog entries atop the semantic diff comment - #9002

Merged
cknitt merged 2 commits into
semantic-diff-loginsfrom
semantic-diff-changelog
Oct 23, 2026
Merged

cknitt merged 2 commits into
semantic-diff-loginsfrom
semantic-diff-changelog

Conversation

@cknitt

@cknitt cknitt commented Oct 23, 2026 •

Copy link
Copy Markdown
Member

Stacked on #9001.

The comment's status line showed the head sha and an update time, both already on the last commit's line. The comment now opens with the pull request's changelog entries under their own heading, followed by the Semantic Diff heading:

Changelog

  • 🚀 Add @instanceOf("Class") and @typeOf("…") for abstract types …
  • 🐛 An untagged variant with both Blob and File cases matches files as File …
  • 🏠 Untagged variants recognize stdlib classes only through their @instanceOf annotations …

Semantic Diff

11 commits · Full page

(#8950's entries, rendered locally.)

  • The changelog fragments describe the pull request as a whole, as its squash commit will; a commit's Breaking: section describes that commit. The entries are the fragments under changes/ that differ between the merge base and the head (git diff --diff-filter=AM), so a fragment edited later shows in its final form and one added and removed again doesn't show.
  • Each bullet is led by its category's emoji as CHANGELOG.md heads the category (scripts/changelog.js's categories), breaking changes first, then in the changelog's order. Fragments are parsed with the changelog's own parseFragment; one that doesn't parse shows its file name with ❔.
  • A pull request without fragments reads "No changelog entry." under the Changelog heading.
  • When commits have Breaking: sections but no entry is a breaking change, or the other way round, a note under the list says so.
  • Fragment Markdown is kept as written, except that @name outside backticks is drawn as code so it notifies no one.

New tests: entries from a range (breaking first, an added-then-removed fragment and README.md left out, an invalid name), and the heading's list, empty state and breaking notes.

🤖 Generated with Claude Code

https://claude.ai/code/session_01AzPS5F8RDSGZ6dhfK6NdZp

@cknitt cknitt added the changelog:skip No release notes needed label Oct 23, 2026
@github-actions

github-actions Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

Changelog

No changelog entry.

Semantic Diff

2 commits · Full page

List the pull request's changelog entries atop the comment

bc14dfc · cknitt + Claude · Oct 23, 2026, 16:33 UTC

The heading repeated the last commit's sha and a time. The comment now opens with a Changelog section listing the entries the pull request adds, each led by its category's emoji as in the changelog, and noting breaking commits without a breaking entry or the other way round; the Semantic Diff heading follows.

✨ Keep the changelog entries within the comment's budget

995e632 · cknitt + Claude · Oct 23, 2026, 16:43 UTC · new

The budget shortened only commits, so fragments of more than the budget would have pushed the comment past GitHub's limit (Codex). The changelog takes at most a quarter of the budget; entries past it are counted.

@cknitt
cknitt added this pull request to stack #9003 October 23, 2026 16:33
@cknitt
cknitt marked this pull request as ready for review October 23, 2026 16:36
@cknitt

cknitt commented Oct 23, 2026

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ac564d3d44

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread scripts/recordMarkdown.js Outdated
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-23T16:46:11.029254Z 995e632 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@cknitt
cknitt force-pushed the semantic-diff-changelog branch from ac564d3 to e58b6ff Compare October 23, 2026 16:41
The heading repeated the last commit's sha and a time. The comment now
opens with a Changelog section listing the entries the pull request adds,
each led by its category's emoji as in the changelog, and noting breaking
commits without a breaking entry or the other way round; the Semantic
Diff heading follows.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AzPS5F8RDSGZ6dhfK6NdZp
Signed-off-by: Christoph Knittel <ck@cca.io>
@cknitt
cknitt force-pushed the semantic-diff-changelog branch from e58b6ff to bc14dfc Compare October 23, 2026 16:41
@cknitt cknitt changed the title List the pull request's changelog entries in the semantic diff comment List the pull request's changelog entries atop the semantic diff comment Oct 23, 2026
The budget shortened only commits, so fragments of more than the budget
would have pushed the comment past GitHub's limit (Codex). The changelog
takes at most a quarter of the budget; entries past it are counted.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AzPS5F8RDSGZ6dhfK6NdZp
Signed-off-by: Christoph Knittel <ck@cca.io>
@cknitt

cknitt commented Oct 23, 2026

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Already looking forward to the next diff.

Reviewed commit: 995e632aac

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@cknitt
cknitt requested a review from cristianoc October 23, 2026 16:52
@pkg-pr-new

pkg-pr-new Bot commented Oct 23, 2026

Copy link
Copy Markdown

Open in StackBlitz

rescript

npm i https://pkg.pr.new/rescript@9002

@rescript/belt

npm i https://pkg.pr.new/@rescript/belt@9002

@rescript/darwin-arm64

npm i https://pkg.pr.new/@rescript/darwin-arm64@9002

@rescript/linux-arm64

npm i https://pkg.pr.new/@rescript/linux-arm64@9002

@rescript/linux-x64

npm i https://pkg.pr.new/@rescript/linux-x64@9002

@rescript/runtime

npm i https://pkg.pr.new/@rescript/runtime@9002

@rescript/win32-x64

npm i https://pkg.pr.new/@rescript/win32-x64@9002

commit: 995e632

@cknitt
cknitt merged commit 29cf759 into master Oct 23, 2026
26 checks passed
@cknitt
cknitt deleted the semantic-diff-changelog branch October 23, 2026 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog:skip No release notes needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants