Repository navigation
List the pull request's changelog entries atop the semantic diff comment - #9002
Conversation
ChangelogNo changelog entry. Semantic Diff2 commits · Full page List the pull request's changelog entries atop the commentbc14dfc · cknitt + Claude · Oct 23, 2026, 16:33 UTC The heading repeated the last commit's sha and a time. The comment now opens with a Changelog section listing the entries the pull request adds, each led by its category's emoji as in the changelog, and noting breaking commits without a breaking entry or the other way round; the Semantic Diff heading follows. ✨ Keep the changelog entries within the comment's budget995e632 · cknitt + Claude · Oct 23, 2026, 16:43 UTC · new The budget shortened only commits, so fragments of more than the budget would have pushed the comment past GitHub's limit (Codex). The changelog takes at most a quarter of the budget; entries past it are counted. |
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ac564d3d44
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
ac564d3 to
e58b6ff
Compare
The heading repeated the last commit's sha and a time. The comment now opens with a Changelog section listing the entries the pull request adds, each led by its category's emoji as in the changelog, and noting breaking commits without a breaking entry or the other way round; the Semantic Diff heading follows. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AzPS5F8RDSGZ6dhfK6NdZp Signed-off-by: Christoph Knittel <ck@cca.io>
e58b6ff to
bc14dfc
Compare
The budget shortened only commits, so fragments of more than the budget would have pushed the comment past GitHub's limit (Codex). The changelog takes at most a quarter of the budget; entries past it are counted. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AzPS5F8RDSGZ6dhfK6NdZp Signed-off-by: Christoph Knittel <ck@cca.io>
|
@codex review |
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
rescript
@rescript/belt
@rescript/darwin-arm64
@rescript/linux-arm64
@rescript/linux-x64
@rescript/runtime
@rescript/win32-x64
commit: |
Stacked on #9001.
The comment's status line showed the head sha and an update time, both already on the last commit's line. The comment now opens with the pull request's changelog entries under their own heading, followed by the Semantic Diff heading:
(#8950's entries, rendered locally.)
Breaking:section describes that commit. The entries are the fragments underchanges/that differ between the merge base and the head (git diff --diff-filter=AM), so a fragment edited later shows in its final form and one added and removed again doesn't show.CHANGELOG.mdheads the category (scripts/changelog.js'scategories), breaking changes first, then in the changelog's order. Fragments are parsed with the changelog's ownparseFragment; one that doesn't parse shows its file name with ❔.Breaking:sections but no entry is a breaking change, or the other way round, a note under the list says so.@nameoutside backticks is drawn as code so it notifies no one.New tests: entries from a range (breaking first, an added-then-removed fragment and
README.mdleft out, an invalid name), and the heading's list, empty state and breaking notes.🤖 Generated with Claude Code
https://claude.ai/code/session_01AzPS5F8RDSGZ6dhfK6NdZp