Repository navigation
Parse changelog fragments without the release script's dependencies - #9004
Conversation
The Semantic Diff workflow runs commitRecords.js without node_modules, and changelog.js now imports magicNumbers.js, which imports semver, so every pull request's semantic diff failed. Fragment parsing moves to changelogFragments.js, which imports nothing, and a test keeps the renderer's imports to Node's modules and its own files. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AzPS5F8RDSGZ6dhfK6NdZp Signed-off-by: Christoph Knittel <ck@cca.io>
ChangelogNo changelog entry. Semantic Diff1 commit · Full page Parse changelog fragments without the release script's dependenciesedad641 · cknitt + Claude · Oct 23, 2026, 17:34 UTC The Semantic Diff workflow runs commitRecords.js without node_modules, and changelog.js now imports magicNumbers.js, which imports semver, so every pull request's semantic diff failed. Fragment parsing moves to changelogFragments.js, which imports nothing, and a test keeps the renderer's imports to Node's modules and its own files. |
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
rescript
@rescript/belt
@rescript/darwin-arm64
@rescript/linux-arm64
@rescript/linux-x64
@rescript/runtime
@rescript/win32-x64
commit: |
|
Developer playground preview: https://rescript-lang.github.io/rescript/dev-playground/?version=pr-9004 |
Fixes the Semantic Diff check failing on every pull request since #9000 and #9002 met on master (e.g. #8950):
#9002 made
commitRecords.jsimportchangelog.jsfor the changelog's categories andparseFragment. #9000 madechangelog.jsimportmagicNumbers.js, which importssemver. The Semantic Diff workflow runscommitRecords.jswithout installingnode_modules(deliberately: for fork pull requests it runs only the base branch's code and installs nothing), so the import fails.categories,parseFragmentand the PR-link patterns move to a newscripts/changelogFragments.js, which imports nothing.changelog.jsimports them from there and re-exportscategories,parseFragmentandplaceholderLink, so its importers and tests are unchanged.commitRecords.jsimports fromchangelogFragments.js.commitRecords.test.js: follows the renderer's imports fromcommitRecords.jsand fails on any that is neithernode:nor a relative file. On master's version it fails withmagicNumbers.js imports semver.Checked by running the renderer from a copy of
scripts/with nonode_modulesanywhere around it: master's version fails as above, this one starts.🤖 Generated with Claude Code
https://claude.ai/code/session_01AzPS5F8RDSGZ6dhfK6NdZp