Skip to content

Draw a pull request's commit authors by their GitHub login - #9001

Merged
cknitt merged 1 commit into
masterfrom
semantic-diff-logins
Oct 23, 2026
Merged

cknitt merged 1 commit into
masterfrom
semantic-diff-logins

Conversation

@cknitt

@cknitt cknitt commented Oct 23, 2026

Copy link
Copy Markdown
Member

Follow-up to #8998: the semantic diff page and comment draw each commit's author by GitHub login, linked to the profile, instead of the git name:

93a3aef · cknitt + Claude · Oct 23, 2026, 15:09 UTC

  • Git doesn't know logins, so the workflow asks GitHub's API (/pulls/N/commits, one request per 100 commits), which links a commit to the account its email belongs to, and passes the map to commitRecords.js --logins <file>.
  • The login is a plain link, not an @ mention, so nobody is notified.
  • A commit whose email belongs to no account, an unusual login (e.g. bot[bot]), a failed API call, or a local make semantic-diff keeps the author's name.
  • Co-authors keep their names: the API gives logins only for authors, and looking up a co-author's email would take a search request each and fails for private emails.

New test: --logins drawing a known author as a link on the page and in the comment, and falling back to the name otherwise.

🤖 Generated with Claude Code

https://claude.ai/code/session_01AzPS5F8RDSGZ6dhfK6NdZp

A login is shorter than a name and leads to the person. The workflow asks
GitHub's API for the account each commit's email belongs to, and the page
and comment link the login to the profile (a link, not a mention, which
would notify); a commit without an account keeps the author's name.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AzPS5F8RDSGZ6dhfK6NdZp
Signed-off-by: Christoph Knittel <ck@cca.io>
@cknitt cknitt added the changelog:skip No release notes needed label Oct 23, 2026
@github-actions

Copy link
Copy Markdown

Semantic Diff

1 commit · 8b14387 · Oct 23, 2026, 16:19 UTC · Full page

Draw a pull request's commit authors by their GitHub login

8b14387 · cknitt + Claude · Oct 23, 2026, 16:14 UTC

A login is shorter than a name and leads to the person. The workflow asks GitHub's API for the account each commit's email belongs to, and the page and comment link the login to the profile (a link, not a mention, which would notify); a commit without an account keeps the author's name.

@cknitt
cknitt marked this pull request as ready for review October 23, 2026 16:23
@cknitt

cknitt commented Oct 23, 2026

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-23T16:25:11.104167Z 8b14387 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Another round soon, please!

Reviewed commit: 8b1438789f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@pkg-pr-new

pkg-pr-new Bot commented Oct 23, 2026

Copy link
Copy Markdown

Open in StackBlitz

rescript

npm i https://pkg.pr.new/rescript@9001

@rescript/belt

npm i https://pkg.pr.new/@rescript/belt@9001

@rescript/darwin-arm64

npm i https://pkg.pr.new/@rescript/darwin-arm64@9001

@rescript/linux-arm64

npm i https://pkg.pr.new/@rescript/linux-arm64@9001

@rescript/linux-x64

npm i https://pkg.pr.new/@rescript/linux-x64@9001

@rescript/runtime

npm i https://pkg.pr.new/@rescript/runtime@9001

@rescript/win32-x64

npm i https://pkg.pr.new/@rescript/win32-x64@9001

commit: 8b14387

@github-actions

Copy link
Copy Markdown

@cknitt
cknitt requested a review from cristianoc October 23, 2026 16:52
@cknitt
cknitt merged commit c870b1c into master Oct 23, 2026
26 of 27 checks passed
@cknitt
cknitt deleted the semantic-diff-logins branch October 23, 2026 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog:skip No release notes needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants