Repository navigation
Conversation
…stem The demo catalog in redhat-developer/rhdh renamed the janus-authors Group to rhdh-authors and the janus-idp System to rhdh-examples (rhdh#5827). The Template entities imported from this repository still referenced the old names, so they no longer resolved. Also align create-frontend-plugin, which pointed at red-hat-developer-hub-authors and red-hat-developer-hub, with the same entities. Assisted-by: OpenCode Signed-off-by: Zbyněk Drápela <zbynek.drapela@gmail.com>
The namespace field defaulted to system:janus-idp, which is not a valid Kubernetes namespace name and was never usable. It dates back to b44c160, where a find-and-replace flipped the janus-idp default to system:janus-idp in both the system EntityPicker and the namespace parameter. The namespace stays required, so the template asks for a real value instead of prefilling a broken one. Assisted-by: OpenCode Signed-off-by: Zbyněk Drápela <zbynek.drapela@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: zdrapela The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Member
|
/lgtm |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do / why we need it
Points the catalog metadata of the templates in this repository at the
rhdh-authorsGroup and therhdh-examplesSystem, which replacejanus-authorsandjanus-idpin the RHDH demo catalog.The templates are imported into the same catalog as https://github.com/redhat-developer/rhdh/blob/main/catalog-entities/all.yaml, so once redhat-developer/rhdh#5827 merges, the old names no longer exist and the
owner/systemreferences in everyTemplateentity are dangling.spec.owner: janus-authors->rhdh-authors,spec.system: janus-idp->rhdh-examplesin all 15 templates, includinggithub/backstage-systemandgithub/obc, whichtemplates.yamldoes not import.create-frontend-pluginusedred-hat-developer-hub-authors/red-hat-developer-hub, which never existed in the demo catalog. Aligned with the same entities.github/argocd: dropped thenamespaceparameter default ofsystem:janus-idp. It dates from a find-and-replace that also hit thesystemEntityPicker default, and a Kubernetes namespace name cannot contain:, so the default could never work. The parameter is still required.Should merge after redhat-developer/rhdh#5827.
Left untouched on purpose: the
io.janusMaven defaults in the quarkus and spring-boot templates (they change generated app code),@janus-idp/cli(a real npm package), and thejanus-api-idp/janus-idplinks and "Janus Idp" tags inREADME.md.Which issue(s) does this PR fix
No issue. Follow-up to redhat-developer/rhdh#5827.
How to test changes / Special notes to the reviewer
Load
templates.yamlinto an RHDH instance that also loads the rhdh catalog from redhat-developer/rhdh#5827, and check that the templates' owner and system resolve to therhdh-authorsGroup and therhdh-examplesSystem.https://redhat.atlassian.net/browse/RHDHBUGS-4113