Skip to content

chore: point templates at the rhdh-authors group and rhdh-examples system - #35

Open
zdrapela wants to merge 2 commits into
redhat-developer:mainfrom
zdrapela:chore/drop-janus-idp-name
Open

zdrapela wants to merge 2 commits into
redhat-developer:mainfrom
zdrapela:chore/drop-janus-idp-name

Conversation

@zdrapela

@zdrapela zdrapela commented Nov 12, 2026 •

Copy link
Copy Markdown
Member

What does this PR do / why we need it

Points the catalog metadata of the templates in this repository at the rhdh-authors Group and the rhdh-examples System, which replace janus-authors and janus-idp in the RHDH demo catalog.

The templates are imported into the same catalog as https://github.com/redhat-developer/rhdh/blob/main/catalog-entities/all.yaml, so once redhat-developer/rhdh#5827 merges, the old names no longer exist and the owner/system references in every Template entity are dangling.

  • spec.owner: janus-authors -> rhdh-authors, spec.system: janus-idp -> rhdh-examples in all 15 templates, including github/backstage-system and github/obc, which templates.yaml does not import.
  • create-frontend-plugin used red-hat-developer-hub-authors / red-hat-developer-hub, which never existed in the demo catalog. Aligned with the same entities.
  • github/argocd: dropped the namespace parameter default of system:janus-idp. It dates from a find-and-replace that also hit the system EntityPicker default, and a Kubernetes namespace name cannot contain :, so the default could never work. The parameter is still required.

Should merge after redhat-developer/rhdh#5827.

Left untouched on purpose: the io.janus Maven defaults in the quarkus and spring-boot templates (they change generated app code), @janus-idp/cli (a real npm package), and the janus-api-idp/janus-idp links and "Janus Idp" tags in README.md.

Which issue(s) does this PR fix

No issue. Follow-up to redhat-developer/rhdh#5827.

How to test changes / Special notes to the reviewer

Load templates.yaml into an RHDH instance that also loads the rhdh catalog from redhat-developer/rhdh#5827, and check that the templates' owner and system resolve to the rhdh-authors Group and the rhdh-examples System.

https://redhat.atlassian.net/browse/RHDHBUGS-4113

…stem

The demo catalog in redhat-developer/rhdh renamed the janus-authors Group to
rhdh-authors and the janus-idp System to rhdh-examples (rhdh#5827). The
Template entities imported from this repository still referenced the old
names, so they no longer resolved.

Also align create-frontend-plugin, which pointed at
red-hat-developer-hub-authors and red-hat-developer-hub, with the same
entities.

Assisted-by: OpenCode
Signed-off-by: Zbyněk Drápela <zbynek.drapela@gmail.com>
The namespace field defaulted to system:janus-idp, which is not a valid
Kubernetes namespace name and was never usable. It dates back to
b44c160, where a find-and-replace flipped the janus-idp default to
system:janus-idp in both the system EntityPicker and the namespace
parameter. The namespace stays required, so the template asks for a real
value instead of prefilling a broken one.

Assisted-by: OpenCode
Signed-off-by: Zbyněk Drápela <zbynek.drapela@gmail.com>
@openshift-ci
openshift-ci Bot requested review from Zaperex and gashcrumb November 12, 2026 13:03
@openshift-ci

openshift-ci Bot commented Nov 12, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: zdrapela
Once this PR has been reviewed and has the lgtm label, please assign divyanshigupta for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gustavolira

Copy link
Copy Markdown
Member

/lgtm

@zdrapela

Copy link
Copy Markdown
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants