Skip to content

fix(intelligent-assistant): restore MUI5 IA styles for notebooks and file chips #5020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ciiay wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(intelligent-assistant): restore MUI5 IA styles for notebooks and file chips #5020

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions eslint.frontend-shared.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,10 +62,15 @@ const materialUiMigrationEslintConfig = {
* Shared ESLint config for frontend packages across the rhdh-plugins monorepo.
* Blocks Material UI v4 (@material-ui/*) imports to prevent reintroduction
* after migration to MUI v5 / Backstage UI.
*
* Resolve @backstage/cli from the package/workspace (packageDir), not the
* monorepo root — workspaces pin newer CLI with JSX-transform rules.
*/
module.exports = function createFrontendEslintConfig(packageDir) {
return require('@backstage/cli/config/eslint-factory')(
packageDir,
materialUiMigrationEslintConfig,
const createPackageConfig = require(
require.resolve('@backstage/cli/config/eslint-factory', {
paths: [packageDir],
}),
);
return createPackageConfig(packageDir, materialUiMigrationEslintConfig);
};
5 changes: 5 additions & 0 deletions workspaces/intelligent-assistant/.changeset/quiet-scroll-border.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@red-hat-developer-hub/backstage-plugin-intelligent-assistant': patch
---

Fix MUI5 style regressions: notebooks docked scroll, file chip outline border, footer divider, and document row alignment
31 changes: 14 additions & 17 deletions ...spaces/intelligent-assistant/plugins/intelligent-assistant/src/components/FilePreview.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
*/

import Box from '@mui/material/Box';
import Divider from '@mui/material/Divider';
import { FileDetailsLabel } from '@patternfly/chatbot';

import { useFileAttachmentContext } from './AttachmentContext';
Expand Down Expand Up @@ -57,22 +56,20 @@ const FilePreview = () => {
}

return (
<>
<Divider />
<Box sx={{ display: 'flex', gap: '10px' }}>
{fileContents.map((file, index) => (
<FileDetailsLabel
key={index}
fileName={file.name}
isLoading={isLoadingFile[file.name]}
onClick={onAttachmentClick}
onClose={() => {
removeFile(index);
}}
/>
))}
</Box>
</>
<Box sx={{ display: 'flex', gap: '10px' }}>
{fileContents.map((file, index) => (
<FileDetailsLabel
key={index}
fileName={file.name}
isLoading={isLoadingFile[file.name]}
variant="outline"
onClick={onAttachmentClick}
onClose={() => {
removeFile(index);
}}
/>
))}
</Box>
);
};

Expand Down
5 changes: 5 additions & 0 deletions ...ces/intelligent-assistant/plugins/intelligent-assistant/src/components/LightSpeedChat.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,6 +335,11 @@ const StyledChatbotFooter = styled(ChatbotFooter)(({ theme }) => ({
backgroundColor: `${floatingBg} !important`,
alignItems: 'stretch',
},
// ChatbotFooter always injects an <hr>; MessageBar already has its own edge,
// so the line reads as an extra divider above file chips / the input.
'& > .pf-v6-c-divider': {
display: 'none',
},
'&>.pf-chatbot__footer-container': {
width: '100% !important',
maxWidth: 'unset !important',
Expand Down
Loading
Loading