Skip to content

fix(intelligent-assistant): restore MUI5 IA styles for notebooks and file chips - #5020

Open
ciiay wants to merge 1 commit into
redhat-developer:mainfrom
ciiay:rhdhbugs-3751-mui5-style-breakage
Open

ciiay wants to merge 1 commit into
redhat-developer:mainfrom
ciiay:rhdhbugs-3751-mui5-style-breakage

Conversation

@ciiay

@ciiay ciiay commented Sep 28, 2026 •

Copy link
Copy Markdown
Member

Description

Fixes MUI5 style regressions reported against the Intelligent Assistant overlay/notebooks UI: docked notebooks landing content can scroll again, chat file attachment chips restore an outline border, the extra PatternFly footer divider above attachments is hidden, and notebook document rows vertically align the type badge, filename, and kebab via PatternFly Flex.

Also resolves workspace lint-staged picking up an outdated root @backstage/cli ESLint factory (keeps react/react-in-jsx-scope off for the JSX transform).

Fixed

  • RHDHBUGS-3751 — [IA] : Some styles are breaking on migrating MUI4 to MUI5

UI before changes

Before fix

UI after changes

After fix

Recordings captured with APP_MODE=nfs (packages/app new frontend) against a local yarn start session (app-config.yaml + app-config.local.yaml).

Test Plan

  • Overlay on /settings (light mode) still shows a clear panel edge/shadow
  • Docked Notebooks empty landing scrolls when content overflows (Important alert does not cover Add a resource)
  • Chat file attachment chips show a visible outline border
  • Attaching a file does not show an extra purple hr above the chip/message bar
  • Notebook document row: type badge, filename, and ⋮ kebab align on hover

Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or Updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)

Note

This bug fix was identified and implemented using the bug-fix and raise-pr agent skills. Please verify the fix thoroughly before merging.

…file chips

Fixes: https://redhat.atlassian.net/browse/RHDHBUGS-3751
Signed-off-by: Yi Cai <yicai@redhat.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@rhdh-gh-app

rhdh-gh-app Bot commented Sep 28, 2026

Copy link
Copy Markdown

Changed Packages

Package Name Package Path Changeset Bump Current Version
@red-hat-developer-hub/backstage-plugin-intelligent-assistant workspaces/intelligent-assistant/plugins/intelligent-assistant patch v5.3.3

@sonarqubecloud

Copy link
Copy Markdown

@codecov

codecov Bot commented Sep 28, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 72.97297% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.65%. Comparing base (3b8e60a) to head (e281274).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5020   +/-   ##
=======================================
  Coverage   63.65%   63.65%           
=======================================
  Files        2705     2705           
  Lines      106578   106582    +4     
  Branches    30023    30021    -2     
=======================================
+ Hits        67842    67845    +3     
- Misses      36947    36948    +1     
  Partials     1789     1789           
Flag Coverage Δ *Carryforward flag
adoption-insights 84.77% <ø> (ø) Carriedforward from 3b8e60a
ai-integrations 87.10% <ø> (ø) Carriedforward from 3b8e60a
app-defaults 68.03% <ø> (ø) Carriedforward from 3b8e60a
augment 46.67% <ø> (ø) Carriedforward from 3b8e60a
boost 92.39% <ø> (ø) Carriedforward from 3b8e60a
bulk-import 73.12% <ø> (ø) Carriedforward from 3b8e60a
cost-management 13.56% <ø> (ø) Carriedforward from 3b8e60a
dcm 74.29% <ø> (ø) Carriedforward from 3b8e60a
e2e-adoption-insights 60.00% <ø> (ø) Carriedforward from 3b8e60a
e2e-extensions 62.31% <ø> (ø) Carriedforward from 3b8e60a
e2e-global-header 52.40% <ø> (ø) Carriedforward from 3b8e60a
e2e-homepage 61.11% <ø> (ø) Carriedforward from 3b8e60a
e2e-intelligent-assistant 45.49% <ø> (-0.03%) ⬇️ Carriedforward from 3b8e60a
e2e-orchestrator 49.49% <ø> (ø) Carriedforward from 3b8e60a
e2e-orchestrator-plugin 49.48% <ø> (ø) Carriedforward from 3b8e60a
e2e-quickstart 54.83% <ø> (ø) Carriedforward from 3b8e60a
e2e-scorecard 49.77% <ø> (ø) Carriedforward from 3b8e60a
e2e-theme 16.36% <ø> (ø) Carriedforward from 3b8e60a
extensions 58.30% <ø> (ø) Carriedforward from 3b8e60a
global-floating-action-button 71.18% <ø> (ø) Carriedforward from 3b8e60a
global-header 69.10% <ø> (ø) Carriedforward from 3b8e60a
homepage 55.05% <ø> (ø) Carriedforward from 3b8e60a
install-dynamic-plugins 73.52% <ø> (ø) Carriedforward from 3b8e60a
intelligent-assistant 78.53% <72.97%> (+<0.01%) ⬆️
konflux 91.98% <ø> (ø) Carriedforward from 3b8e60a
lightspeed 69.02% <ø> (ø) Carriedforward from 3b8e60a
mcp-integrations 84.46% <ø> (ø) Carriedforward from 3b8e60a
orchestrator 77.69% <ø> (ø) Carriedforward from 3b8e60a
quickstart 65.83% <ø> (ø) Carriedforward from 3b8e60a
sandbox 79.56% <ø> (ø) Carriedforward from 3b8e60a
scorecard 88.98% <ø> (ø) Carriedforward from 3b8e60a
theme 87.70% <ø> (ø) Carriedforward from 3b8e60a
translations 7.91% <ø> (ø) Carriedforward from 3b8e60a
x2a 78.48% <ø> (ø) Carriedforward from 3b8e60a

*This pull request uses carry forward flags. Click here to find out more.


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b8e60a...e281274. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant