[Symfony61] Skip CommandConfigureToAttributeRector on non-constant configure() values - #1057
Merged
Merged
Conversation
TomasVotruba
enabled auto-merge (squash)
August 25, 2026 15:44
…nfigure() values Attribute arguments must be constant expressions, so a runtime value like $this->setDescription($this->description) cannot be inlined into #[AsCommand]. Leave such setX() calls in configure() instead of producing invalid code. Also return null when nothing could be extracted, so the rule no longer reports a no-op change. Reported in #1054. Co-authored-by: Alessandro Lai <alessandro.lai85@gmail.com>
TomasVotruba
force-pushed
the
fix-command-configure-non-constant
branch
from
August 25, 2026 15:45
894f90a to
ac8f297
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the regression reported in #1054.
CommandConfigureToAttributeRectorinlined the argument ofsetName()/setDescription()/setAliases()/setHidden()straight into#[AsCommand], without checking it is a compile-time constant. A runtime value produced invalid PHP:Now the rule only extracts scalar / const-fetch / class-const / constant-array values and leaves any non-constant
setX()call untouched inconfigure():class ExampleCommand extends Command { public function __construct(private readonly string $description) {} public function configure(): void { $this->setDescription($this->description); } }Also returns
nullwhen nothing could be extracted, so the rule no longer reports a no-op change.Credit to @Jean85 for the report and reproduction fixture in #1054.