Conversation
CommandConfigureToAttributeRector should not run if the promoted value is a non-constant value, since it cannot be included as an attribute argument
Member
|
Thanks for the report and fixture! Confirmed the rule emitted invalid PHP ( |
TomasVotruba
added a commit
that referenced
this pull request
Aug 25, 2026
…nfigure() values Attribute arguments must be constant expressions, so a runtime value like $this->setDescription($this->description) cannot be inlined into #[AsCommand]. Leave such setX() calls in configure() instead of producing invalid code. Also return null when nothing could be extracted, so the rule no longer reports a no-op change. Reported in #1054. Co-authored-by: Alessandro Lai <alessandro.lai85@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CommandConfigureToAttributeRector should not run if the promoted value is a non-constant value, since it cannot be included as an attribute argument