Repository navigation
Use umbrella headers in ImageProps.h and ComponentDescriptorFactory.h (#59025) - #59025
Closed
j-piasecki wants to merge 1 commit into
Closed
j-piasecki wants to merge 1 commit into
j-piasecki wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
p: Software Mansion
|
@j-piasecki has exported this pull request. If you are a Meta employee, you can view the originating Diff in D124947284. |
meta-codesync
Bot
changed the title
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Oct 13, 2026
…react#59025) Summary: "For frameworks" headers `ImageProps.h` and `ComponentDescriptorFactory.h` included public module headers directly, so including them under `RN_STRICT_API` failed the umbrella guard. They now include `<React/*.h>` umbrellas instead. `react_renderer_animations` now links `rrc_image` so `<React/ImageManager.h>` is on its CMake include path. Changelog: [Internal] Differential Revision: D124947284
j-piasecki
force-pushed
the
export-D124947284
branch
2 times, most recently
from
October 13, 2026 12:50
a8a44aa to
5a46506
Compare
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Oct 13, 2026
…react#59025) Summary: "For frameworks" headers `ImageProps.h` and `ComponentDescriptorFactory.h` included public module headers directly, so including them under `RN_STRICT_API` failed the umbrella guard. They now include `<React/*.h>` umbrellas instead. `react_renderer_animations` now links `rrc_image` so `<React/ImageManager.h>` is on its CMake include path. Changelog: [Internal] Differential Revision: D124947284
…react#59025) Summary: "For frameworks" headers `ImageProps.h` and `ComponentDescriptorFactory.h` included public module headers directly, so including them under `RN_STRICT_API` failed the umbrella guard. They now include `<React/*.h>` umbrellas instead. `react_renderer_animations` now links `rrc_image` so `<React/ImageManager.h>` is on its CMake include path. Changelog: [Internal] Differential Revision: D124947284
j-piasecki
force-pushed
the
export-D124947284
branch
from
October 13, 2026 13:00
5a46506 to
190700a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
"For frameworks" headers
ImageProps.handComponentDescriptorFactory.hincluded public module headers directly, so including them underRN_STRICT_APIfailed the umbrella guard. They now include<React/*.h>umbrellas instead.react_renderer_animationsnow linksrrc_imageso<React/ImageManager.h>is on its CMake include path.Changelog: [Internal]
Differential Revision: D124947284