Use umbrella headers in ImageProps.h and ComponentDescriptorFactory.h (#59025)

Summary:

"For frameworks" headers `ImageProps.h` and `ComponentDescriptorFactory.h` included public module headers directly, so including them under `RN_STRICT_API` failed the umbrella guard. They now include `<React/*.h>` umbrellas instead. `react_renderer_animations` now links `rrc_image` so `<React/ImageManager.h>` is on its CMake include path.

Changelog: [Internal]

Differential Revision: D124947284

Author: j-piasecki

packages/react-native/Package.swift

@@ -465,6 +465,7 @@ let reactCore = RNTarget(
 let reactFabric = RNTarget(
   name: .reactFabric,
   path: "ReactCommon/react/renderer",
+  searchPaths: ["ReactCommon/react/renderer/imagemanager/platform/ios"], // ImageProps.h pulls in <React/ImageManager.h>; depending on reactImageManagerApple would be circular
   excludedPaths: [
     "animated/tests",
     "animationbackend/tests",

packages/react-native/ReactCommon/React-Fabric.podspec

@@ -120,6 +120,8 @@ Pod::Spec.new do |s|
         "\"$(PODS_TARGET_SRCROOT)/react/renderer/core\"",
         "\"$(PODS_TARGET_SRCROOT)/react/renderer/componentregistry\"",
         "\"$(PODS_TARGET_SRCROOT)/react/renderer/debug\"",
+        "\"$(PODS_TARGET_SRCROOT)/react/renderer/imagemanager\"",
+        "\"$(PODS_TARGET_SRCROOT)/react/renderer/imagemanager/platform/ios\"",
       ]
     end
 

packages/react-native/ReactCommon/react/renderer/animations/CMakeLists.txt

@@ -26,6 +26,7 @@ target_link_libraries(react_renderer_animations
         react_renderer_graphics
         react_renderer_mounting
         react_renderer_uimanager
+        rrc_image
         rrc_view
         runtimeexecutor
         yoga

packages/react-native/ReactCommon/react/renderer/componentregistry/ComponentDescriptorFactory.h

@@ -11,11 +11,9 @@
 
 #include <memory>
 
-#include <react/renderer/core/ComponentDescriptor.h>
-#include <react/renderer/core/EventDispatcher.h>
-#include <react/utils/ContextContainer.h>
-
-#include "ComponentDescriptorRegistry.h"
+#include <React/ComponentRegistry.h>
+#include <React/RendererCore.h>
+#include <React/Utils.h>
 
 namespace facebook::react {
 

packages/react-native/ReactCommon/react/renderer/components/image/ImageProps.h

@@ -12,10 +12,10 @@
 #include <optional>
 #include <string>
 
-#include <react/renderer/components/view/ViewProps.h>
-#include <react/renderer/core/PropsParserContext.h>
-#include <react/renderer/graphics/Color.h>
-#include <react/renderer/imagemanager/primitives.h>
+#include <React/Graphics.h>
+#include <React/ImageManager.h>
+#include <React/RendererCore.h>
+#include <React/View.h>
 
 namespace facebook::react {