Skip to content

fix(sdk): add a cancel button to the delete domain dialog #2033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rohanchkrabrty merged 2 commits into from
Nov 3, 2026
Merged

fix(sdk): add a cancel button to the delete domain dialog #2033

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
45ba87e
fix(sdk): add a cancel button to the delete domain dialog
rohanchkrabrty Oct 30, 2026
1a60dd0
Merge branch 'main' into fix/delete-domain-cancel-button
rohanchkrabrty Nov 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions web/sdk/client/views/security/components/delete-domain-dialog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,6 +188,18 @@ function DeleteDomainContent({
</Flex>
</AlertDialog.Body>
<AlertDialog.Footer>
<AlertDialog.Close
Comment thread
rohanchkrabrty marked this conversation as resolved.
Resolved
render={
<Button
variant="outline"
color="neutral"
disabled={isPending}
data-test-id="frontier-sdk-delete-domain-cancel-btn"
>
Cancel
</Button>
}
/>
{isDomainLoading ? (
<Skeleton height={32} width={120} />
) : (
Expand Down
Loading