You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(sdk): add a cancel button to the delete domain dialog - #2033
Add a Cancel button to the delete domain dialog on the Security page. Before this, the dialog had only the delete button, so users had to refresh the page to leave it.
Cancel uses AlertDialog.Close with an outline neutral Button, the same pattern as the delete organization dialog. It closes the dialog without a delete call, and it is disabled while the delete is pending.
Cancel stays visible while the domain loads. Only the delete button swaps for its skeleton.
The delete domain dialog had only the delete button, so users could not
go back to the security page without a refresh. Add a Cancel button that
closes the dialog, the same as the delete organization dialog. Cancel
stays visible while the domain loads and is disabled while the delete
is pending.
raystack/frontier#2025: This PR applies the AlertDialog pattern to the delete organization dialog’s Cancel button.
Suggested reviewers:rohilsurana
Merge Risk: Minimal · previous review 45ba8
The requested cancel behavior is implemented without an established correctness or availability risk.
Pre-merge checks: 2
Check name
Status
Explanation
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Tip
🎯 Customize your risk assessments
Guide how CodeRabbit assesses merge risk and security architecture risk. Highlight sensitive changes and explain your security boundaries using Merge Risk Instructions and Security Risk Instructions in your review settings. Security architecture risk assessments require the Advanced plan or above.
✅ Automatic approvals, with your rules
Let CodeRabbit approve pull requests once required threads are resolved, pre-merge checks pass, and your risk limits are met. Enable Automatic approvals in review settings, with overrides for teams or file paths.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 0 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AlertDialog.Closewith an outline neutralButton, the same pattern as the delete organization dialog. It closes the dialog without a delete call, and it is disabled while the delete is pending.