Repository navigation
ci: fix both 7502 candidate build failures (macOS XCTest hosted-window flag, Windows NSIS RestartManager template) - #1431
Merged
Conversation
…st step The sea render fixtures from #1426 fail closed without TEST_RUNNER_TONO_HOSTED_WINDOW_DIAGNOSTIC=1. macos-ci.yml sets it; the release workflow's "TonoTests XCTest target" step did not, so the first 7502 candidate (run 37651992656) failed 14 assertions and built nothing. Same env as CI, no test skipped or loosened. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TCaYZLcT8rtQDuuTVhSPaC
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
…AppIsRunning
@tauri-apps/cli 2.12.1 ships a utils.nsh whose CheckIfAppIsRunning uses the
Windows Restart Manager and takes the executable path. The upstream template
adds `!include "Win\RestartManager.nsh"` and passes
"$INSTDIR\${MAINBINARYNAME}.exe"; our custom installer.nsi had neither, so the
7502 Windows candidate (run 37651997330) died in makensis with
`macro named "RestartManager_StartSession" not found`. Same two changes as
upstream tauri-cli-v2.12.1, nothing else. windows-packaging.test.mjs 38/38.
Also corrects the changelog: MacSeaPolishRenderTests skips without the flag;
only MacUsabilityRenderTests fails closed (review a9401457 opus:F1).
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01TCaYZLcT8rtQDuuTVhSPaC
Owner
Author
|
jev-route review record — decision
Verification by the merging agent
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Owner order 2026-10-07 (decision 071): build the 0.0.75 candidates from main with Mac polish A only.
The first 7502 macOS candidate, run 37651992656, failed in the
buildjob's "TonoTests XCTest target" step: 642 tests, 14 failures, allMacUsabilityRenderTests.swift:560 … exact-window native acceptance unavailable; TEST_RUNNER_TONO_HOSTED_WINDOW_DIAGNOSTIC=1 required. The sea render fixtures from #1426 fail closed without that flag;macos-ci.ymlsets it on both XCTest steps,macos-release.ymldid not. Nothing was signed or packaged.Change: the release workflow's XCTest step gets the same
envas CI. No test is skipped or loosened.Verification
gh run view 37651992656 --log-failed).release/macos; this PR's ci-gate has no called workflow for.github/workflows/macos-release.yml(BUILD_AND_TEST: release workflows need no called workflow) and is not evidence that the step passes.Candidates
release/macos,release/windows,stability/desktop-0.0.75-20261005are atf73300c13; after merge they are fast-forwarded to this PR's merge SHA and both platforms are rebuilt from it with release sequence 7503. The paired Windows 7502 run 37651997330 (environmentwindows-releaseself-approved per decision 023 at 2026-10-07T16:36Z) is superseded, not used.Limitations
macos-release.ymlandmacos-ci.ymlcarry two hand-written copies of the XCTest step; folding them into one reusable workflow is a later engineering item.Record:
docs/changelog.d/2026-10-07-macos-release-hosted-window-flag.md(SHIP_PLAN G1/G2 candidates).🤖 Generated with Claude Code
https://claude.ai/code/session_01TCaYZLcT8rtQDuuTVhSPaC