Repository navigation
test(windows): fail packaging tests when installer.nsi lags the @tauri-apps/cli pin - #1433
Merged
Merged
Conversation
…i-apps/cli pin The forked NSIS template still consumes the bundler's utils.nsh, so a cli upgrade must be diffed against the upstream template (#1421 -> #1431 was not, and the 7502 Windows candidate died in makensis). installer.nsi carries a TEMPLATE_SYNCED_WITH_TAURI_CLI marker; one test asserts it equals package.json's @tauri-apps/cli and that the 2.12 contract holds (RestartManager include, full executable path at both CheckIfAppIsRunning sites). Red on a stale marker and on a bare-name call site, 39/39 green. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TCaYZLcT8rtQDuuTVhSPaC
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Owner
Author
|
jev-route review record — decision
Verification (merging agent)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1431's limitation. Ops plan (build-chain regression guard, not a ship gate).
packages/windows/installer.nsiis a fork of tauri-bundler's template, bututils.nshis still supplied by the bundler at build time. #1421 moved@tauri-apps/cli2.11.5 → 2.12.1 without diffing the upstream template and the 7502 Windows candidate died in makensis.installer.nsigets a; TEMPLATE_SYNCED_WITH_TAURI_CLI <version>marker.windows-packaging.test.mjs: the marker must equalpackage.json's@tauri-apps/cli, and the 2.12 contract must hold (!include "Win\RestartManager.nsh", bothCheckIfAppIsRunningsites pass"$INSTDIR\${MAINBINARYNAME}.exe"). Bumping the cli pin now requires re-diffingcrates/tauri-bundler/src/bundle/windows/nsis/and moving the marker.Verification
node --test apps/windows/app/scripts/windows-packaging.test.mjs: 39/39.@tauri-apps/cli is 2.12.1 but installer.nsi was last synced with 2.11.5); one call site reverted to the bare exe name → 1 fail; restored → 39/39.Limitations
macos-release.ymlandmacos-ci.ymlis a separate PR.Record:
docs/changelog.d/2026-10-07-nsis-template-sync-guard.md.🤖 Generated with Claude Code
https://claude.ai/code/session_01TCaYZLcT8rtQDuuTVhSPaC