Repository navigation
feat(macos): whole-window sea polish A - #1426
Conversation
|
First hosted compile of 0685f5d reported two bounded renderer errors (CGFloat→NSNumber stop and luminance expression type-check timeout). Both corrected; latest head also anchors evidence output to apps/macos and retains canonical Windows sunset day/path/light durations. New CI pending, no native or visual acceptance claimed. First failure log retained locally; not loosening any render/OCR assertion. |
|
a07fbfb Release app, policy-tests and privileged-tests passed; XCTest did not compile because the native SwiftUI accessibility keys are read-only. Fixed with shared display inputs (production reads OS, fixtures inject identical presentation values without modifying host preferences). Normal whole-window poses now use real initial Full mounts/live loops; transitions/navigation are tested on the same persistent window. CPU receipts explicitly describe synthetic UI-host scope, not production connected-device acceptance. Latest CI pending; no visual/CPU pass claimed. |
|
第一批真实原生证据(bded69b8 / run37530231293):应用/策略/helper通过,632 XCTest(1 skipped、1 failure);新整窗和动效测试确实执行通过,但旧stored-off夹具有1个alpha254像素失败。原图分析arrival亮度单调,rise/set的严格整窗指标失败,未放宽断言或修改原PNG。首批窗口尺寸/页面继承/过渡未稳态也已识别,不能当作规格验收。454a26ff修补不透明SwiftUI底、原生窗口请求尺寸/明确断言、状态和稳态页面夹具;另修星点层级CSS覆盖与LowPower下Auto采样。ci-gate37532863763待跑,仍草稿;无B/C/D、安装、发布或G1/G2改动。完整原证据和检查范围记录在本PR changelog及共享MAC-POLISH-A-CODEX-STATE.md。 |
|
454a原生续测仍失败:634tests/1skipped/17failures。1280×720真实窗口面/页面选择/稳态图已修对并实际看过;920高度在toolbar首次布局后仍增4pt,严格alpha仍1个254像素。8b5d8e73再从源码/原生夹具修:toolbar首次布局之后重新设置请求外窗;首页胶囊填充/描边/材质/点击区域统一用CSS圆弧几何(SwiftUI默认continuous会延伸接缝)。未放宽尺寸或透明度断言,未修饰PNG。run37534975917待验证,原始亮度指标仍未裁定;A未通过、B未开始。 |
Package A frame review (spec §4) — head 82b91e6, ci-gate run 37591069668Reviewer: Claude session (spec author), not the owner. Evidence: artifact Looked at (contact sheets built from the unmodified PNGs, then crops at 2×): the three 16-frame strips (rise, arrival, set), all 24 whole-window captures en/zh × 920/1280 (7 states + 5 pages each), the 12 accessibility captures, the 4 water frames, Measured (mean luminance of each whole frame, 0–255):
Verdict: A is accepted on the scene, the transitions, the whole-window layout and the secondary pages. Two items before it merges:
Not blocking, to list in the PR body as limitations: fixed-surface mount; CPU figure is synthetic-host scope; the connected sun rim shimmers by sub-pixel anti-aliasing (not a sky change). B does not start before these two land. The jev-route review of this head is running in parallel; its receipt follows as a separate comment. |
A final presentation correction — 0527cd5The spec-author frame review of 82b91e6 is recorded at issuecomment-6034002168. I have pushed the headline correction: title and subtitle are keyed as one group; the opacity transition has disjoint incoming/outgoing visible intervals. It does not delay the state, scene or buttons; Reduce Motion replaces immediately. One narrow XCTest covers the visible-interval contract. New 0/1-frame crops and actual native verification are pending ci-gate37594110843. No Windows changes/B work. The parallel review is for 82b91e6, not this new head. Please record its exact coverage; this delta is only Dashboard text presentation, its XCTest and records, no new lifecycle/helper/routing logic. Do not merge until exact-head gate and final evidence are ready. Real installed-window evidence is not yet available. Read-only local inspection found /Applications/Tono.app is signed 0.0.74, not this UI. The current regular CI beta has TeamIdentifier=not set, Signature=adhoc and 82b91e6 actual CI: 635 tests / 1 skipped / 0 failures, Chinese narrow run 1 test / 0 failures, gate success. Raw A originals (118) and logs retained. The root analyzer uses linear sRGB/Rec709 and still flags the rise first delta -0.002673285; set passes (23.67046% maximum drop, endpoint difference 0.000003508), arrival and Full water pass. The spec author's 0–255 image-mean metric has different values/noise interpretation; its acceptance is not relabelled as a pass of the root's strict metric. PR limitations now include fixed-AppKit-surface mount, synthetic-host CPU scope and sun-disc-rim sub-pixel anti-aliasing shimmer. Actual screenshot timing brackets retained. A has two remaining premerge items; B remains unstarted. No install, signing, customer publication or G1/G2 change occurred. |
|
jev-route review record — decision
Confirmed minors (verifier in brackets):
Grok (effort low, 5m31) reported clean with 6 checks; Opus 9m13 and Codex 8m34 found the seven above. Recorded as a jev-route calibration point (Grok low on a code diff). |
0527cd5 to
4570901
Compare
One minor-fix round + current head4570901, rebased conflict-free onto main0ec8bab3f5a09cf5b0da15ee5b6278150b11f8db. ci-gate37596390930 pending. B not started; no Windows/Core/Services/helper/PF changes. 3173f320 actual
Title proof correction: 0527cd5 gate passed, but root viewed all six 0/1 originals and found first-frame fix merely moved residual double exposure into frame1. Retained as FAIL, not visually accepted. This head replaces one text group while invisible between90ms exit/130ms entrance; no outgoing/incoming view pair, inherited whole-surface legacy animation disabled for sea Home only. Quick canceled transition back to the shown text restores opacity. New 0/1 originals/crops still pending. All six review findings have in-PR fragments pending native verification/review; not closed by source edits. Current changes include new cancellation/resize/expiry lifecycles, so independent current-increment coverage remains required before merge. Installed-window item remains unavailable, as recorded in issuecomment-6034120799: local signed app0.0.74 is not this UI; regular CI beta strict verification fails and is not a supported helper-authenticated install. Did not replace/erase old app, re-sign locally, bypass authentication or alter candidate trust guards. Need a current-head installable signed artifact / approved packaging host, or explicit clarification of whether production WindowGroup launch evidence (not an installed release candidate) is acceptable. Fixed-surface screenshots alone do not satisfy it. |
Package A re-judgement — head 4570901, ci-gate run 37596390930Looked at: the frame 0–4 headline crops of all three strips from this run's artifact, set frames 0–2 at full scene size, and recomputed every series.
Package A is accepted on frames. Merge waits only on the jev-route continuation review of this head (run |
|
jev-route review record — decision
Remaining limitations (one defect, found by both vendors, introduced by the opus:F1 resize fix)
Left open by the owner's stop rule after one fix round; the fix (anchor the transform at (0,0) or add the translation) goes into package B's first commit, not another A round. |
Final records-only head — 07ee967Pushed ten docs files only, source/apps/workflows/tooling identical to reviewed4570901eb. Exact-head gate37599813927 pending; it actually reruns macOS against the whole PR, not skipped jobs. No more A source fixes / no B push. Added the two requested R1426 open fragments, one same-cause defect, exact stop-rule limitation; appended same changelog. Existing3173 labels are seven review labels in six root-cause fragments (O:F4 also covers C:F2). Review/CI closure recorded. Ledger defines fixed(main SHA) as actually merged, so these six + title retain in-PR until Claude's actual merge SHA exists; after merge they can be changed to fixed(real merge SHA), not a pre-merge457 head. Read actual7957497e result/meta/trace: completed/PASSED, exact457/base0ec8, seven prior labels rechecked three ways, two minors/zero blockers/unverified; Codex finder gpt-6.1-sol/high. Headline visual evidence is root/spec-author, not falsely attributed to a reviewer that lacked the images. All120 original delivery images individually viewed,120 hashes byte-identical;17 derived proof images viewed. Full list/provenance/notes: Production installedWindowGroup capture explicitly deferred to first signed0.0.75/G1 per your6034801982 comment; fixed-AppKit-surface/syntheticCPU/sunrim limitations remain. No install/signing/customer publication/owner acceptance claim. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Scope / ship plan
Mac polish A only, presentation preparation for
docs/SHIP_PLAN.md0.0.75 G1/G2. No UI auto-merge. B may be prepared but not pushed until A is on main; Claude owns this manual merge.Windows scene scalar endpoints,11 byte-identical PNG textures and ambient clocks ported to a persistent native CALayer graph behind the whole window. Home/Sidebar follow M1–M3. Phase authority and
seaToggleConnectionremain byte-identical; no Windows/Core/Services/helper/PF/routing/account/update implementation changes.Locked clarifications
Current source / verification
~/Downloads/Tono/mac-polish-a-20261006/4570-delivery/IMAGE-INSPECTION.md/original-image-manifest.json; first-source artifacts linked from the source CI run. No original image edits.title-proof/three-transitions-0-1.pnglabels the requested crops and provenance.20.8 21.1 22.4 23.5 25.2 27.1 29.3 31.6 34.2 36.8 39.3 42.0 44.1 45.9 47.3 47.8; arrival52.0 51.9 52.3 52.9 53.4 54.1 54.9 55.7 56.4 57.0 57.7 58.0 58.2 58.4 58.6 58.6; set54.0 53.9 50.3 44.7 38.6 33.2 29.3 26.6 24.7 23.8 23.3 22.9 22.6 22.4 22.2 22.1. Set max single drop 19.0907% of total (≤25%); night mean delta0.006486 on0–255 scale. Source Windows timings untouched. Full water changed72437/87114 pixels.Independent review / stop rule
in-PRbecause A is not yet on main; after merge usefixed(<actual main merge SHA>). This avoids falsely recording a PR head as a main merge.Additive en → zh resources
Lite → 轻量; View steps → 查看步骤; Restore normal internet → 恢复普通网络; %lld ms → %lld 毫秒. Existing safety wording not shortened.
Limitations / not release acceptance
Only source/docs, no new signed candidate, installation, customer-channel publish or owner G1/G2 sign-off.
docs/changelog.d/2026-10-06-macos-polish-a.mdretains all prior failures and new reviewed range/CI/limitations.