Repository navigation
IRaindexV7: OrderCalculateReverted - #80
Closed
thedavidmeister wants to merge 10 commits into
Closed
thedavidmeister wants to merge 10 commits into
thedavidmeister wants to merge 10 commits into
Conversation
…s own eval IRaindexV7 replaces clear3 with clear4 (new selector) so callers carrying V6 clear3 assumptions hard-revert instead of silently changing semantics. IRaindexV6 and its taker interfaces move to deprecated/v6. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
takeOrders4 skips an order whose calculate eval reverts, has no interpreter code, returns undecodable data or too few outputs, emitting OrderCalculateReverted. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 35 minutes. View limit details
No actionable comments were generated in the recent review.
 |
| Layer / File(s) | Summary |
|---|---|
Dependency and import updates foundry.toml, remappings.txt, src/interface/deprecated/* |
The rainlang-interface dependency and remapping now use version 0.2.14. Deprecated interface imports use updated package versions and paths. |
V7 Raindex interface src/interface/IRaindexV7.sol, CLAUDE.md |
IRaindexV7 adds configuration types, events, errors, and function declarations for vault, task, order, quote, take, clear, and flash-lending operations. CLAUDE.md updates the current-interface entry, type names, and versioned naming examples to V7. |
V7 taker callbacks src/interface/IRaindexV7OrderTaker.sol, src/interface/IRaindexV7ArbOrderTaker.sol |
IRaindexV7OrderTaker declares the onTakeOrders2 callback. IRaindexV7ArbOrderTaker extends that interface with the payable arb6 entry point. |
Priority:
Estimated code review effort: 3 (Moderate) | ~20 minutes
Change: Feature
Possibly related PRs
- rainlanguage/raindex.interface#77: Updates the same dependency and import surfaces; this pull request moves those references from version 0.2.13 to 0.2.14 while adding V7 interfaces.
- rainlanguage/raindex.interface#79: Adds the V7 interface family; this pull request adds
OrderCalculateRevertedand updates V7 declarations and callback types. - rainlanguage/raindex.interface#78: Documents the unsupported dynamic-balance-token behavior for V6; this pull request documents the same restriction for V7.
Merge Risk: 
00c2f
-
This change adds V7 interface declarations and updates deprecated imports and dependency pins. It adds no runtime behavior in this repository. No actionable merge-blocking risk remains.
Pre-merge checks: 
-
Check name Status Explanation Description Check Check skipped - CodeRabbit’s high-level summary is enabled. Title check The title clearly identifies the main change: adding the OrderCalculateReverted event to IRaindexV7. Docstring Coverage No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0… Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Full details: Docstring Coverage
-
Explanation
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (12 skipped: 12 unsupported.)
-
Finishing Touches: 💡 1
-
🛠️ Fix failing CI checks: 💡
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
Every signed context in IRaindexV7 is now an EIP-712 SignedContextV2 from IInterpreterCallerV5. Structs carrying signed context are re-versioned (TaskV3, TakeOrderConfigV5, TakeOrdersConfigV6, QuoteV3) and every function and event whose ABI changes takes the next version number. rainlang-interface is pinned to the rainlang.interface#134 merge commit until it publishes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…to 2026-10-25-raindex-v7-order-calculate-reverted
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
thedavidmeister
changed the base branch from
2026-10-25-raindex-v7-clear4
to
main
October 26, 2026 17:53
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…7-order-calculate-reverted
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
QA
RaindexV6TakeOrderCalculateRevertTest).OrderCalculateReverted(address,address,bytes32), which the raindex.deploy tests decode from recorded logs.🤖 Generated with Claude Code
Summary by CodeRabbit
New Features
Documentation