Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/23390
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 84780b8 with merge base 0b3d26d ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
Bot
added
the
CLA Signed
Summary:
Materialize the selected Core AI source bundle on disk under the assets root,
so the SDK can specialize it.
- Source preparation (`runtime/coreai_assets.{h,mm}`): read inline bundle
files through `NamedDataMap` and write them unchanged under the assets root,
keyed by the export-time bundle digest (no runtime payload hashing). Reuse
checks the exact file set, sizes, entry types and directory structure.
Incomplete or malformed existing sources fail without being replaced, since
an SDK model may still be using them. Same-size content changes are not
detected.
- Cold publication stages into `.staging-<uuid>` and publishes with
`renameatx_np(RENAME_EXCL)`, with inspection, staging and publication all
relative to one open root descriptor. If another loader publishes first, its
bundle is validated and used.
- Tests: adds the filesystem snapshot helpers used from here on.
- SDK acquisition is not included here.
- README: the "Asset storage" materialization, publication and completeness
text.
No changes outside `backends/apple/coreai`.
Test Plan:
```
# Local: configure and build only
cmake -S . -B build -G Ninja -DCMAKE_BUILD_TYPE=Release \
-DCMAKE_OSX_DEPLOYMENT_TARGET=27.0 -DEXECUTORCH_BUILD_COREAI=ON \
-DEXECUTORCH_BUILD_TESTS=ON -DEXECUTORCH_BUILD_EXTENSION_DATA_LOADER=ON
cmake --build build --target backends/apple/coreai/all
# CI (macOS 27 runner, .github/workflows/coreai.yml)
ctest --test-dir build/backends/apple/coreai --output-on-failure --no-tests=error
```
CTest runs `coreai_host_test`, which adds the source suite.
ExclusivePublicationValidatesWinnerAndRemovesLosingStaging covers the
concurrent `RENAME_EXCL` race.
metascroy
force-pushed
the
coreai-v2/03b-source-bundles
branch
from
October 5, 2026 03:14
9d457ae to
84780b8
Compare
metascroy
force-pushed
the
coreai-v2/03a-bookmarks
branch
from
October 5, 2026 03:14
f74a984 to
68a8b17
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Materializes the selected Core AI source bundle under the assets root so the SDK can specialize it (
runtime/coreai_assets.{h,mm}).NamedDataMapand write them unchanged, keyed by the export-time bundle digest (no runtime payload hashing)..staging-<uuid>and publishes withrenameatx_np(RENAME_EXCL), all relative to one open root descriptor. If another loader publishes first, its bundle is validated and used.coreai_host_test, plus the filesystem snapshot helpers used from here on.ExclusivePublicationValidatesWinnerAndRemovesLosingStagingcovers the concurrentRENAME_EXCLrace.No changes outside
backends/apple/coreai.Stack: 4 of 9, based on #23389. Review only this PR's commit. Next: #23391.
Test plan: built locally for macOS 27.0;
ctest -Nlistscoreai_host_test, which the Core AI workflow runs on the macOS 27 runner.lintrunneris clean.