Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/23389
Note: Links to docs will display an error until the docs builds have been completed. ❌ 5 Cancelled Jobs, 2 PendingAs of commit 68a8b17 with merge base 0b3d26d ( CANCELLED JOBS - The following jobs were cancelled. Please retry:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
Bot
added
the
CLA Signed
Summary:
Persist the raw SDK bookmark for a selected Core AI bundle, so later loads can
restore a specialized model without re-reading the payload.
- Bookmarks (`runtime/coreai_bookmarks.{h,mm}`): store raw opaque bookmarks
(at most 8 MiB) with atomic publication. Keys include the bundle digest,
platform, architecture and persistence policy, but not function bindings or
delivery location. Per-key OS locks coordinate threads and processes.
- SDK acquisition and cache removal are not included here.
- README: the "Asset storage" key derivation, bookmark bound and locking text.
Trust model: the application owns the assets root and is trusted not to modify
it while the backend uses it.
No changes outside `backends/apple/coreai`.
Test Plan:
```
# Local: configure and build only
cmake -S . -B build -G Ninja -DCMAKE_BUILD_TYPE=Release \
-DCMAKE_OSX_DEPLOYMENT_TARGET=27.0 -DEXECUTORCH_BUILD_COREAI=ON \
-DEXECUTORCH_BUILD_TESTS=ON -DEXECUTORCH_BUILD_EXTENSION_DATA_LOADER=ON
cmake --build build --target backends/apple/coreai/all
# CI (macOS 27 runner, .github/workflows/coreai.yml)
ctest --test-dir build/backends/apple/coreai --output-on-failure --no-tests=error
```
CTest runs `coreai_host_test`, which adds the bookmark suite, including a
cross-process lock test that spawns child processes.
metascroy
force-pushed
the
coreai-v2/02-filesystem
branch
from
October 5, 2026 03:14
aa99feb to
7998984
Compare
metascroy
force-pushed
the
coreai-v2/03a-bookmarks
branch
from
October 5, 2026 03:14
f74a984 to
68a8b17
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Persists the raw SDK bookmark for a selected Core AI bundle, so later loads can restore a specialized model without re-reading the payload (
runtime/coreai_bookmarks.{h,mm}).coreai_host_test, including a cross-process lock test that spawns child processes.No changes outside
backends/apple/coreai.Stack: 3 of 9, based on #23388. Review only this PR's commit. Next: #23390.
Test plan: built locally for macOS 27.0;
ctest -Nlistscoreai_host_test, which the Core AI workflow runs on the macOS 27 runner.lintrunneris clean.