Skip to content

ci: address zizmor findings #3871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ArthurSens merged 1 commit into from
Oct 29, 2026
Merged

ci: address zizmor findings #3871

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/dependabot.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@ updates:
prometheus:
patterns:
- "github.com/prometheus/*"
cooldown:
default-days: 7
- package-ecosystem: "github-actions"
directory: "/"
schedule:
Expand All @@ -42,3 +44,5 @@ updates:
- .github/workflows/govulncheck.yml
- .github/workflows/scorecards.yml
- .github/workflows/stale.yml
cooldown:
default-days: 7
4 changes: 3 additions & 1 deletion .github/workflows/approve-workflows.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,12 @@
###
# This action is synced from https://github.com/prometheus/prometheus
###

name: Approve pending workflows

on:
issue_comment:
# The pinned action requires triage access or higher and only calls GitHub APIs.
issue_comment: # zizmor: ignore[dangerous-triggers]
types: [created]

permissions: read-all
Expand Down
9 changes: 5 additions & 4 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ jobs:
- uses: actions/setup-go@b7ad1dad31e06c5925ef5d2fc7ad053ef454303e # v7.0.0
with:
go-version: 1.27.x
cache: false

@SuperQ SuperQ Oct 26, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure this one is a false-positive since there is no publish in this flow.

CC @ArthurSens

@ArthurSens ArthurSens Oct 26, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, we probably want to ignore this one

@ArthurSens ArthurSens Oct 29, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm merging even if this one isn't solved because the next repo_sync will fix this

- run: uname -a
- run: make test-e2e

Expand Down Expand Up @@ -98,17 +99,17 @@ jobs:
- uses: prometheus/promci-artifacts/restore@9ca3252d07f230d5f923452b4df5697eba4a5bee # v0.1.1
- name: Build docker image
run: |
if [[ "${{ github.ref }}" == refs/tags/* ]]; then
make docker DOCKER_IMAGE_TAG=${{ github.ref_name }}
if [[ "${GITHUB_REF}" == refs/tags/* ]]; then
Comment thread
TheMeier marked this conversation as resolved.
Resolved
make docker DOCKER_IMAGE_TAG="${GITHUB_REF_NAME}"
else
make docker
fi
- run: docker images
- run: docker run --rm -t -v "$(pwd):/app" "${DOCKER_TEST_IMAGE_NAME}" -i "${REPO_PATH}" -T
- name: Test docker image
run: |
if [[ "${{ github.ref }}" == refs/tags/* ]]; then
make test-docker DOCKER_IMAGE_TAG=${{ github.ref_name }}
if [[ "${GITHUB_REF}" == refs/tags/* ]]; then
make test-docker DOCKER_IMAGE_TAG="${GITHUB_REF_NAME}"
else
make test-docker
fi
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/golangci-lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ jobs:
uses: actions/setup-go@b7ad1dad31e06c5925ef5d2fc7ad053ef454303e # v7.0.0
with:
go-version: 1.27.x
cache: false

@SuperQ SuperQ Oct 26, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here, I think we added a nolint in the upstream prometheus version.

- name: Install snmp_exporter/generator dependencies
run: sudo apt-get update && sudo apt-get -y install libsnmp-dev
if: github.repository == 'prometheus/snmp_exporter'
Expand Down
Loading