Repository navigation
ci: address zizmor findings - #3871
Merged
Merged
Conversation
Contributor
Author
|
regards #3867 |
Contributor
Author
|
@SuperQ HTH, If not just close it and sorry for the noise |
SuperQ
reviewed
Oct 26, 2026
| - uses: actions/setup-go@b7ad1dad31e06c5925ef5d2fc7ad053ef454303e # v7.0.0 | ||
| with: | ||
| go-version: 1.27.x | ||
| cache: false |
Member
There was a problem hiding this comment.
I'm pretty sure this one is a false-positive since there is no publish in this flow.
CC @ArthurSens
Member
There was a problem hiding this comment.
yep, we probably want to ignore this one
Member
There was a problem hiding this comment.
I'm merging even if this one isn't solved because the next repo_sync will fix this
SuperQ
reviewed
Oct 26, 2026
| uses: actions/setup-go@b7ad1dad31e06c5925ef5d2fc7ad053ef454303e # v7.0.0 | ||
| with: | ||
| go-version: 1.27.x | ||
| cache: false |
Member
There was a problem hiding this comment.
Same here, I think we added a nolint in the upstream prometheus version.
Member
|
Yea, this is helpful. It's just tedious. :) |
ArthurSens
reviewed
Oct 26, 2026
TheMeier
force-pushed
the
zizmor
branch
2 times, most recently
from
October 27, 2026 03:37
b9e1ab8 to
8b3b7b5
Compare
ArthurSens
reviewed
Oct 27, 2026
Signed-off-by: Christoph Maser <christoph.maser+github@gmail.com>
ArthurSens
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.