Skip to content

Refactor image source definition #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DebakelOrakel merged 2 commits into from
Aug 26, 2026
Merged

Refactor image source definition #52

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aca0741
Refactor image source definition
DebakelOrakel Aug 26, 2026
932dbd8
Apply suggestions from review
DebakelOrakel Aug 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions class/defaults.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,5 +12,11 @@ parameters:

images:
metrics_server:
image: registry.k8s.io/metrics-server/metrics-server
tag: v0.6.1
registry: registry.k8s.io
repository: metrics-server/metrics-server
Comment thread
simu marked this conversation as resolved.
Resolved
tag: v0.9.0

helm_values:
image:
repository: ${metrics_server:images:metrics_server:registry}/${metrics_server:images:metrics_server:repository}
tag: ${metrics_server:images:metrics_server:tag}
15 changes: 6 additions & 9 deletions class/metrics-server.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,24 +5,21 @@ parameters:
source: ${metrics_server:charts:metrics-server:source}
chart_name: metrics-server
version: ${metrics_server:charts:metrics-server:version}
output_path: dependencies/metrics-server/helmcharts/metrics-server/${metrics_server:charts:metrics-server:version}/
output_path: ${_base_directory}/helmcharts/metrics-server/${metrics_server:charts:metrics-server:version}/
compile:
- input_paths:
- metrics-server/component/app.jsonnet
- ${_base_directory}/component/app.jsonnet
input_type: jsonnet
output_path: .
- input_paths:
- metrics-server/component/main.jsonnet
- ${_base_directory}/component/main.jsonnet
input_type: jsonnet
output_path: metrics-server/
output_path: ${_instance}/
- output_path: metrics-server/01_helmchart
input_type: helm
input_paths:
- metrics-server/helmcharts/metrics-server/${metrics_server:charts:metrics-server:version}
helm_values:
image:
repository: ${metrics_server:images:metrics_server:image}
tag: ${metrics_server:images:metrics_server:tag}
- ${_base_directory}/helmcharts/metrics-server/${metrics_server:charts:metrics-server:version}
helm_values: ${metrics_server:helm_values}
helm_params:
release_name: metrics-server
namespace: ${metrics_server:namespace}
3 changes: 1 addition & 2 deletions tests/defaults.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1 @@
parameters:
metrics_server: {}
# params here
2 changes: 1 addition & 1 deletion ...aults/metrics-server/metrics-server/01_helmchart/metrics-server/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ spec:
- --kubelet-preferred-address-types=InternalIP,ExternalIP,Hostname
- --kubelet-use-node-status-port
- --metric-resolution=15s
image: registry.k8s.io/metrics-server/metrics-server:v0.6.1
image: registry.k8s.io/metrics-server/metrics-server:v0.9.0
imagePullPolicy: IfNotPresent
livenessProbe:
failureThreshold: 3
Expand Down
Loading