Repository navigation
Refactor image source definition - #52
Merged
Merged
Conversation
This PR changes how images are defined in the component. It is a breaking change, but follows recommended syntaxt for image handling.
|
🚀 This PR has been released as Triggering workflows 🛠️ Auto tagging enabled with label |
simu
requested changes
Aug 26, 2026
simu
left a comment
simu
left a comment
Member
There was a problem hiding this comment.
The change seems unnecessarily complicated. We don't need all the fancy Helm values rendering here, since we don't need to configure anything special.
Additionally, if we don't want to set the image tag in the component defaults, we should completely drop images and instead tell users to override the image through the components' helm_values parameter, then we don't need the helm.jsonnet indirection either.
DebakelOrakel
force-pushed
the
change/improve-helm-values-rendering
branch
from
August 26, 2026 07:56
922913d to
932dbd8
Compare
DebakelOrakel
added
change
bump:minor
breaking
bump:major
and removed
breaking
bump:major
change
bump:minor
labels
simu
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes how images are defined in the component.
It is a breaking change, but follows recommended syntaxt for image handling.
Checklist
changelog.
The PR has a meaningful description that sums up the change. It will be
linked in the changelog.
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog.