Add plugin-specific login completion guidance - #281
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Essentials Run ID: 📒 Files selected for processing (7)
Included review availability: 4 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour. Summary by CodeRabbit
WalkthroughThe Priority: ⬇️ Low Merge Risk: ⚪ Minimal · up to The plugin login guidance is ready to merge after normal checks; non-interactive environments continue to use service tokens. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 16.67% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 6 functions across 6 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Comment |
commit: |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
|
Reviewed CodeRabbit’s approval of b50b587. There are no inline findings or actionable code comments to resolve. The docstring-coverage warning is advisory; the new presentation option is documented in its type, command help, and product contract, and behavior is covered by authentication tests. Adding boilerplate to existing callbacks and test helpers would not improve this focused change. All CI checks, including CodeRabbit, are green on the reviewed commit. |
## Overview Prepare the coordinated CLI release from `8.0.0-rc.15` to `8.0.0-rc.16`. Main now includes the reviewed and merged plugin login guidance in #281, along with the other changes accumulated since the previous release. **Leave this PR unmerged until the team has reviewed and tested the release. Merging it triggers publication under `latest`; auto-merge is not enabled.** ## Changes - Run the repository’s version-bump script to advance lockstep manifests and internal workspace references, with the matching lockfile and bundled platform-skill version stamp. - Preserve the independently versioned engine and Compute packages and all existing external product pins. No product implementation or authentication changes are introduced by this release diff. ## Why A dedicated release PR gives maintainers a single coordination point before publication, following the [versioning procedure](https://github.com/prisma/prisma-cli/blob/main/docs/oss/versioning.md). The desktop Prisma plugin still waits for an exact published CLI version and fresh-user acceptance before activating its new onboarding. ## Validation and coordination - Passed: frozen installation, build, typecheck, lint, 80 versioning/script tests, skill packaging, CLI tests (1,019 passed; 2 skipped), and wrapper tests (3 passed). - Release conformance passed: **0 failing, 6 allowed findings** across both installed binaries. The allowed findings are main’s existing transition from engine `0.4.0` to `0.6.0`: Composer CLI and ORM toolchain still peer `0.4.0`, and the installed trees contain both versions. The existing exceptions require follow-up family releases peering `0.6.0`; this PR does not add or widen those exceptions. - **Local macOS test issue:** the full workspace test run fails `packages/cli-engine/tests/clack-prompts.test.ts` → `consent with a token: a wrong answer re-prompts instead of failing` at the 5,000 ms timeout. The same focused test fails before the bump at `b50b587`, so this is not introduced by the version diff. Reproduce with `pnpm --filter @prisma/cli-engine exec vitest run tests/clack-prompts.test.ts` (Node 24.16.0, pnpm 11.6.0, macOS). Other executed engine tests passed; the release still needs team review of this result. - #281 had green CI and CodeRabbit approval before merge. Fresh desktop signup and live plugin deployment on the published version remain pending; those are not claimed by these checks.
1 participant
Overview
Prisma plugin users complete sign-in in a browser, then continue in ChatGPT. The current completion page sends them to a terminal and asks them to install skills they already have.
Changes
auth login --ui-context prisma-plugin, validated before login starts and passed through the login operation to both callback rendering paths.Why
This is an invocation-local presentation choice. Keeping OAuth, scopes, consent, callback validation, session storage, and terminal output unchanged limits the change to the plugin handoff. The plugin will use a verified, exact published CLI version after this ships; no installed-package patch or floating dependency is needed.
Verification
pnpm typecheckandpnpm lintpassed.pnpm --filter @prisma/cli test: 1,019 passed, 2 skipped.pnpm --filter @prisma/cli test:e2e: 7 local checks passed, 48 cloud tests skipped without isolated credentials; interactive login is already excluded from real-API automation.prismawrapper and checked the shipped login help. Compared unmarked completion HTML with main for known, missing, and escaped workspace names: identical.