Add CI for frontend/nextjs (install, lint, test, build)#42
Merged
Conversation
CI workflow runs on pushes to master and PRs that touch frontend/nextjs/** or the workflow itself. Steps: 1. pnpm install --frozen-lockfile - preinstall runs pnpm audit + pnpm audit signatures, so a vulnerable or unsigned package fails the install before anything else runs. 2. pnpm run lint -> tsc --noEmit 3. pnpm run test -> tsc --noEmit 4. pnpm run build -> next build with dummy PLUGGY_CLIENT_ID / PLUGGY_CLIENT_SECRET (read at module init in pages/api/token.ts; no runtime calls made during build). Scripts added to package.json: - typecheck: tsc --noEmit (named target for "the code compiles") - lint: tsc --noEmit (was `next lint`, which prompts an interactive ESLint-config wizard when no config exists and is also deprecated in newer Next.js. The quickstart deliberately ships without an ESLint setup, so for CI purposes lint = the type check. Users wanting real lint can add eslint-config-next on their fork.) - test: tsc --noEmit (placeholder until real tests exist) Concurrency-cancel older runs on the same ref. Verified end-to-end locally with Node 24.14.1 + pnpm 11.1.1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a GitHub Actions workflow that validates `frontend/nextjs` on every push to master and every PR that touches its files.
Workflow
`.github/workflows/frontend-nextjs-ci.yml` — path-filtered to `frontend/nextjs/**` + the workflow file itself. Concurrency-cancels older runs on the same ref.
Steps:
Script changes
`frontend/nextjs/package.json` adds:
`next lint` triggers an interactive ESLint-config wizard when no config exists, and is also deprecated in current Next.js. The quickstart deliberately ships without an ESLint setup, so for CI purposes `lint` is the type check. Users wanting real ESLint can add `eslint-config-next` on their own fork.
Verification