Add CI for vercel-quickdeploy-nextjs (install, lint, test, build)#43
Merged
Conversation
CI workflow runs on pushes to master and PRs that touch examples/vercel-quickdeploy-nextjs/** or the workflow itself. Steps: 1. pnpm install --frozen-lockfile - preinstall runs pnpm audit + pnpm audit signatures, so a vulnerable or unsigned package fails CI before any other step. 2. Lint -> pnpm run typecheck (tsc --noEmit). `pnpm run lint` (real `eslint .`) currently surfaces 19 React-anti-pattern findings in source code that are out of scope here; tighten the CI lint step when those are addressed. 3. Test -> pnpm run test (tsc --noEmit). Placeholder until real tests exist. 4. Build -> pnpm run build (next build) with dummy env vars. The API routes read PLUGGY_*, NEXT_PUBLIC_SUPABASE_URL, and SUPABASE_SERVICE_ROLE_KEY at module init; dummies are enough for bundling, no runtime calls happen at build time. Scripts added to package.json: - typecheck: tsc --noEmit - test: tsc --noEmit (placeholder) Existing `lint` / `lint:fix` (eslint) kept for developer use.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a GitHub Actions workflow that validates `examples/vercel-quickdeploy-nextjs` on every push to master and every PR that touches its files. Same shape as the workflows landed for `aws-sst` (#41) and `frontend/nextjs` (#42).
Workflow
`.github/workflows/vercel-quickdeploy-ci.yml` — path-filtered, concurrency-cancelled. Steps:
Why typecheck for the lint step
`pnpm run lint` here is the real `eslint .` setup (with `eslint-config-next` + the new `core-web-vitals` rules). On current `master` it surfaces 19 React-anti-pattern findings — none of them auto-fixable — that need source code changes. Those are out of scope for "add CI." The Lint step uses `tsc --noEmit` until the source is addressed; tighten it to `pnpm run lint` in a follow-up PR.
Script changes
`examples/vercel-quickdeploy-nextjs/package.json`:
Verification
Follow-up