Conversation
Step A1 of #199. The CMS UI loads Tailwind with a plain import, so its theme variables, preflight and utilities land in the declared theme, base and utilities layers instead of a top-level cmsui layer. The reset now sits below every other layer. Removes the cmsui layer and adds the plone-content layer for block content CSS. The quanta table row drag handle no longer relies on the global reset to drop the basic button styles.
* origin/main: Fix the server not loading translations, which broke hydration (#207)
* origin/main: Releasing @plone/aurora 1.0.0-alpha.16 Release @plone/contents 1.0.0-alpha.3 Release @plone/publicui 1.0.0-alpha.8 Release @plone/cmsui 1.0.0-alpha.11 Release @plone/agave 1.0.0-alpha.8 Release @plone/theming 1.0.0-alpha.8 Release @plone/layout 1.0.0-alpha.13 Release @plone/blocks 1.0.0-alpha.17 Release @plone/plate 1.0.0-alpha.22 Release @plone/react-router 2.0.0-alpha.7 Release @plone/helpers 2.0.0-alpha.9 Release @plone/registry 4.0.0-alpha.4 Release @plone/quanta 1.0.0-alpha.1 Release @plone/components 5.0.0-alpha.5 Release @plone/client 2.0.0-alpha.8 Release @plone/icons 1.0.0-alpha.1 Release @plone/types 3.0.0-alpha.7 Split Quanta and icons out of @plone/components into @plone/quanta and @plone/icons (#212) # Conflicts: # packages/cmsui/styles/cmsui.css
The quanta Table moved from @plone/components to @plone/quanta in #212.
Member
Author
Synced with
|
Member
Author
|
LGTM! |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Step A1 of #199: the Tailwind reset in the CMS UI moves out of the top cascade layer, and the
plone-contentlayer for block content CSS is added.Changes
@plone/cmsui(styles/cmsui.css): the@layer cmsui { … }wrapper is dropped, and Tailwind is loaded with a plain@import 'tailwindcss', as@plone/theming/styles/tailwind.cssalready does for Agave. Tailwind's parts now land in the declared layers:cmsuithemecmsui, the top layerbasecmsuiutilities@plone/componentsbasic themecmsuitheme(@import … layer(theme)):root/.darktokenscmsuitheme@theme,@plugin,@sourceand@custom-variantstay top-level.@plone/cmsui(index.ts): no longer appendscmsuitoconfig.settings.cssLayers.@plone/theming(index.ts): addsplone-contentto the default layer order, with a comment describing it. The new order is:@plone/components(Table.quanta.tsx): the quanta table row's drag handle now resets the basic button styles itself (padding, border, radius, background, color, font) with utilities. Before this PR, it only looked right because the reset sat in the top layer and beat@plone/components' basic.react-aria-Buttonstyles, which the contents view loads. This was the only regression the move caused; the A0 contents listing screenshot caught it.Visual result
All 20 visual regression tests (native blocks, editor overlays, CMS chrome, contents listing, site frame) are pixel-identical to the screenshots taken on
mainbefore this change. I compared locally withCI=1 --retries=0against reference screenshots generated from the pre-change build. Before the drag-handle fix, only the contents listing differed.To confirm in CI, run the "Visual Regression Tests" workflow on this branch. It's read-only and compares against the baselines from #202's update run. It should be green.
Not changed (from the A0 inventory)
@layer custom(@plone/layoutheader/navigation CSS Modules) now sits above Tailwind utilities on CMS routes. It only targets hashed classes of public header components, and the chrome screenshots show no effect.quanta.css'sbody/:rooton/@@contents, the public:roottokens and heading typography,.block-inner-container, the Maps and Toolbar CSS Modules) still wins over every layer, as before. A3 and Track B deal with the parts that touch block content.Breaking
Add-ons that put CSS in
@layer cmsuiget a layer that's no longer declared. It's appended after all declared layers, so it still wins, but by accident. Such add-ons should move their CSS into one of the declared layers, usuallycustom. The@plone/cmsuinews fragment calls this out.Validation
CI=1 pnpm visual-test --retries=0: 20 passed, pixel-exact against the pre-change reference.pnpm acceptance-test: 164 passed.pnpm --filter @plone/cmsui test --run: 189 passed.pnpm --filter @plone/components test --run: 14 passed.check:tsfor@plone/cmsui,@plone/componentsand@plone/theming: clean.cmsuilayer, with preflight inbase./layers.cssserves the new order.mainwith Fix the server not loading translations, which broke hydration #207, which makes React keep the server-rendered page:/layers.cssis the first stylesheet in the served HTML on every route (public, login, editor, contents), and the order after hydration is the same. Before Fix the server not loading translations, which broke hydration #207, browser checks saw the order of the client re-render only.Part of #199.