Conversation
This was referenced Oct 3, 2026
* b5-code-block: Move the table drag handle fragment to @plone/quanta Releasing @plone/aurora 1.0.0-alpha.16 Release @plone/contents 1.0.0-alpha.3 Release @plone/publicui 1.0.0-alpha.8 Release @plone/cmsui 1.0.0-alpha.11 Release @plone/agave 1.0.0-alpha.8 Release @plone/theming 1.0.0-alpha.8 Release @plone/layout 1.0.0-alpha.13 Release @plone/blocks 1.0.0-alpha.17 Release @plone/plate 1.0.0-alpha.22 Release @plone/react-router 2.0.0-alpha.7 Release @plone/helpers 2.0.0-alpha.9 Release @plone/registry 4.0.0-alpha.4 Release @plone/quanta 1.0.0-alpha.1 Release @plone/components 5.0.0-alpha.5 Release @plone/client 2.0.0-alpha.8 Release @plone/icons 1.0.0-alpha.1 Release @plone/types 3.0.0-alpha.7 Split Quanta and icons out of @plone/components into @plone/quanta and @plone/icons (#212)
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 6 of #200: tables are styled by plain CSS instead of Tailwind utilities, with zero visual change.
Changes
@plone/plate/styles/content.cssnow styles tables in both the public renderer and the editor..slate-tablepy-5.block-table__scroll(new part)overflow-x-auto overflow-y-hidden.block-table__wrapper(new part)group/table relative w-fittable.block-table__table(new part)mr-0 ml-px table h-px table-fixed border-collapsetbody.block-table__table tbodymin-w-full.slate-trh-full.slate-td,.slate-thh-full overflow-visible border-none p-0,bg-(--cellBackground); for headerstext-left font-normal *:m-0::beforeof the cell, plusdata-border-top/right/bottom/left(new attributes)before:absolute before:box-border before:size-full before:content-[''] before:select-none, and per sidebefore:border-{t,r,b,l} before:border-{t,r,b,l}-border.block-table__cell-content(new part)relative z-20 box-border h-full px-4 py-2data-border-<side>attribute for each, in both renderers, through a sharedcellBorderAttributes()helper. The border color reads--block-table-border-color, which falls back to--border.--cellBackground, as before.bg-backgroundgenerates no CSS: the theme has nobackgroundcolor for Tailwind. Cells have always been transparent.group/tableis used by nothing.px-3cell padding;Kept for zero diff: header cells are bold in the editor only
The rendered content has always set header cells to
font-normal, but the editor never did, so the browser's bold applied there. With the rule now shared, the editor's header cells would have become normal weight. To keep this PR zero-diff, the editor addsfont-boldto header cells, with a comment. If we want the editor to match the rendered page, it's a one-line removal with a visual change in the editor screenshot. I'd do that in a follow-up.Tests
New:
plate/acceptance/tests/table-content-css.test.tscompares the computed values these rules set in the public view, under Agave's preflight, with no reset, and under@plone/theming's simple reset:tbody, row, header and data cells, cell content;::beforeborder: sides, style, color, and that it fills its cell.Widths aren't compared directly: they follow the text, and removing the reset also removes the theme's font.
Ratchet:
PENDINGloses thetable,tr,thandtdentries.Validation
CI=1 pnpm visual-test --retries=0: 24/24 pixel-identical. The native-blocks screenshots include a table with a header row, in the public view (desktop and mobile) and in the editor.pnpm acceptance-test: all passed, including the new test.pnpm --filter @plone/plate test --run: 75 passed.check:ts,eslintandstylelint: clean.Part of #200.