Conversation
This was referenced Oct 3, 2026
* b4-lists: Move the table drag handle fragment to @plone/quanta Releasing @plone/aurora 1.0.0-alpha.16 Release @plone/contents 1.0.0-alpha.3 Release @plone/publicui 1.0.0-alpha.8 Release @plone/cmsui 1.0.0-alpha.11 Release @plone/agave 1.0.0-alpha.8 Release @plone/theming 1.0.0-alpha.8 Release @plone/layout 1.0.0-alpha.13 Release @plone/blocks 1.0.0-alpha.17 Release @plone/plate 1.0.0-alpha.22 Release @plone/react-router 2.0.0-alpha.7 Release @plone/helpers 2.0.0-alpha.9 Release @plone/registry 4.0.0-alpha.4 Release @plone/quanta 1.0.0-alpha.1 Release @plone/components 5.0.0-alpha.5 Release @plone/client 2.0.0-alpha.8 Release @plone/icons 1.0.0-alpha.1 Release @plone/types 3.0.0-alpha.7 Split Quanta and icons out of @plone/components into @plone/quanta and @plone/icons (#212)
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 5 of #200: the code block is styled by plain CSS instead of Tailwind utilities, with zero visual change. Its syntax colors become theme tokens.
Changes
@plone/plate/styles/content.cssnow styles the code block in both the public renderer and the editor..slate-code_blockpy-1.block-code_block__frame(new part)relative w-full rounded-md bg-muted/50pre.block-code_block__pre(new part)overflow-x-auto p-8 pr-4 font-mono text-sm leading-[normal] [tab-size:2] print:break-inside-avoid.slate-code_block .hljs-***:[.hljs-…]:…arbitrary variants, plus 13dark:onesTheming tokens. The box background is
--block-code-block-background; it falls back to 50% of--muted, as before. Each syntax color is a--code-token-*custom property that defaults to the current GitHub light color:-keyword,-attribute,-string,-title,-name,-comment,-symbol,-bullet,-section;-additionand-deletion, each with a-background.A theme can retune them, for a dark mode for instance.
dark:variants dropped, as Remove Tailwind from block content in @plone/plate and @plone/blocks #200 planned. Nothing in Aurora sets the.darkclass, so they never applied. Dark content comes from setting the tokens instead.Reset independence:
presets itsmarginandwhite-spaceexplicitly: browsers give it a margin, and@plone/theming's simple reset setswhite-space: pre-wrap.codeinherits thepre's font. Without a reset, browsers givecodea genericmonospacefont at a smaller size.Editor-only controls stay Tailwind: format, language picker and copy buttons.
Pre-existing selector bugs, kept for zero diff
Tailwind turns
_into a space inside arbitrary variants, so three of the original selectors never matched what they meant to:.hljs-built_in(orange).hljs-built inconsoleget no color.hljs-variable.language_(red).hljs-variable.languagethisand similar get the variable blue.hljs-title.class_,.function_….hljs-title.class….hljs-titlealready matches themTo stay zero-diff, the new rules reproduce what actually rendered: no
built_inand novariable.language_rule. Restoring them is a one-line change each, with a visual change. I'd do it in a follow-up if we want GitHub's real colors.Tests
plate/acceptance/tests/code-block-content-css.test.ts. It compares the computed values of every property these rules set in the public view (block, frame,pre,code, and the keyword, title and string token colors) under three conditions:@plone/theming's simple reset.PENDINGloses the wholecode_blockentry.Validation
CI=1 pnpm visual-test --retries=0: 24/24 pixel-identical. The native-blocks screenshots include a highlighted JavaScript code block in the public view (desktop and mobile) and in the editor.pnpm acceptance-test: 175 passed, including the code block width tests.pnpm --filter @plone/plate test --run: 75 passed.check:ts,eslintandstylelint: clean.Part of #200.