fix(herdr): use targeted splits for mirrored reviews - #63
Merged
backnotprop merged 1 commit intoSep 7, 2026
Merged
Conversation
Contributor
|
Merged. I confirmed the Herdr side live before merging: Herdr refuses a target for overlay panes and always opens them in the active tab, while a targeted split lands beside the intended pane, so the split default under Mirror is the right call. Thanks for another precise fix. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
herdr openandherdr lastuse a targeted split when invoked through Herdr Mirror and the configured placement is the default overlay. This puts the review beside the invoking remote pane even when the remote server is focused on another workspace. Explicit command-line/environment placement overrides retain their precedence, and native local actions retain their overlay default.An empty
focused_pane_agentis also treated as no agent. Mirror uses an empty string to prevent Herdr 0.8.2 from backfilling an unrelated globally focused agent when the invoking pane is a shell.Fixes #62. The companion local-focus/rendering work is tracked in nikok6/herdr-mirror#98.
Validation
cargo fmt --all --check,cargo clippy --workspace --all-targets -- -D warnings,cargo test --workspace, andpython3 herdr/test-manifest.pypass. The Herdr tests cover document/reply placement, exact transcript preservation, explicit placement overrides, native overlay behavior, and a shell context with an empty agent label.Isolated and real-SSH Herdr 0.8.2 / Mirror 0.4.2 / Annotate 0.3.0 smokes also exercised the same placement behavior through a packaging adapter around the official Plannotator TUI 0.6.0 binary: actual prefix shortcuts reached the invoking remote tab, and document-tree input switched files. Those smokes include the separate Mirror fixes; this PR alone addresses placement, not local Mirror focus.