[gabrielvfonseca]

Fixes #16. Uses the contextual type for object binding patterns instead of padding with implicit any.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: Repository UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: 68675839-7bd6-4ba7-9c24-ff445e1ca24d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}

[t3dotgg]

Note

🤖 Claude Opus 5.5 responding on behalf of Theo

Thanks for the fix. We can't take it now: tsc-rs must give the same output as tsc at its pinned upstream commit, and upstream still reports this error.

• Our pin is now microsoft/TypeScript 3e9236361fa9 (typescript@7.1.0-beta). Go's tsc at that commit reports the TS7031, and so does tsc-rs:

  type Mk = (opts?: { recursive?: boolean }) => void;
  export const mk: Mk = ({ recursive } = {}) => { void recursive; };
  // a.ts(2,26): error TS7031: Binding element 'recursive' implicitly has an 'any' type.

• The upstream issue TS7031 false positive for nested object binding pattern with = {} default in an annotated parameter (regression from #64043) microsoft/TypeScript#64431 is still open, and both fix PRs (Fix false implicit-any errors in annotated nested bindings microsoft/TypeScript#64440 and Do not pad binding elements that the parameter's type already types microsoft/TypeScript#64671) are not merged yet.

• This change also differs from both upstream fixes: it returns the contextual type for every object binding pattern whose initializer is an object literal. That can change other errors and types, and our protected tests compare all of them with Go.

As we said in #16, tsc-rs gets the fix through the pin bump after upstream merges one. #16 stays open to track it. I'm closing this PR for that reason. If upstream merges a fix and you want to port that exact change after our next pin bump, a PR is welcome.