[gabrielvfonseca]

Addresses #13

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: Repository UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: bb647d5d-f789-4840-8109-08ded819b07a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}

[t3dotgg]

Note

🤖 Claude Opus 5.5 responding on behalf of Theo

Thanks for the PR. We can't take it, for three reasons:

• It does not build. The commit has unresolved merge conflict markers (<<<<<<< HEAD, =======, >>>>>>> f9622b6c8) in crates/ts_goport/src/checker/checker_p19.rs.
• Upstream reports both errors at our pin. tsc-rs must give the same output as tsc at its pinned commit, microsoft/TypeScript 3e9236361fa9 (typescript@7.1.0-beta). Go's tsc at that commit and tsc-rs main give the same output on both repros:
  • const type parameter + union return type: readonly [] not assignable to string[] (inherited from upstream, fixed there since) #13 (ok([]) returned through Ok<string[]> | Err<string>): repro.ts(6,3): error TS2322: Type 'Ok<readonly []>' is not assignable to type 'Err<string> | Ok<string[]>'. The upstream report TS2322: const type parameter infers readonly [], rejected through a union return type (7.1.0-dev regression from typescript-go#4591) microsoft/TypeScript#64690 is still open.
  • TS7031 on a contextually typed parameter with a destructured = {} default #16 (destructured parameter with a = {} default): a.ts(2,26): error TS7031: Binding element 'recursive' implicitly has an 'any' type. TS7031 false positive for nested object binding pattern with = {} default in an annotated parameter (regression from #64043) microsoft/TypeScript#64431 is still open, and neither fix PR (Fix false implicit-any errors in annotated nested bindings microsoft/TypeScript#64440, Do not pad binding elements that the parameter's type already types microsoft/TypeScript#64671) is merged.
• The change is for TS7031 on a contextually typed parameter with a destructured = {} default #16, not const type parameter + union return type: readonly [] not assignable to string[] (inherited from upstream, fixed there since) #13. It returns the contextual type for an object binding pattern with an object literal default. That is the same change as fix(checker): TS7031 on contextually typed destructured param with default #107, which we closed for the same reason. It does not touch const type parameter inference, so it cannot fix const type parameter + union return type: readonly [] not assignable to string[] (inherited from upstream, fixed there since) #13.

Both issues stay open to track the fixes. tsc-rs gets each fix with the first pin bump after upstream merges one. I'm closing this PR. If upstream merges a fix and you want to port that exact change after our next pin bump, a PR is welcome.