fix(web): keep right panel controls clickable - #9517
Merged
maria-rcks merged 2 commits intoSep 4, 2026
Conversation
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 12ccca5. Configure here.
Contributor
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This is a contained UI bug fix that moves existing right-panel controls into an Electron no-drag region when the panel is open and preserves closed-state header controls. Its runtime impact is limited to control reachability and title-bar spacing, with no data, API, security, or product-default changes. You can add or adjust custom eligibility rules. Learn more. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

The Electron drag region around scrollable right-panel tabs intercepted the header controls, and maximizing the panel hid its restore control with the collapsed chat column. This moves the open-panel controls into the tab bar's no-drag area while keeping the closed-state controls in the chat header, so maximize, restore, terminal, and panel toggles remain reachable. Web typecheck, targeted lint, formatting, and real-app interaction checks pass; the existing component tests are blocked before collection by the repository's current vite-plus/test config error.
Note
Low Risk
UI layout and pointer-event behavior only in the chat workspace header and right panel tab bar; no auth, data, or API changes.
Overview
Moves maximize/restore and panel toggle controls into the inline right panel tab bar when that panel is open, instead of leaving them in the fixed chat header where Electron’s tab-bar drag region could swallow clicks.
rightPanelControlsInPanelnow requires the panel to be present and open, so the header showspanelLayoutControlsonly while the inline panel is closed; open inline panels receivelayoutControlsonRightPanelTabsinside a[-webkit-app-region:no-drag]cluster.RightPanelTabstightens title-bar padding when those controls are embedded so window chrome spacing stays correct.Reviewed by Cursor Bugbot for commit b3ceeab. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Fix right panel controls rendering in 'ChatViewContent' and 'RightPanelTabs'
ChatViewContentpasses an inline control cluster (maximize and toggle controls) toRightPanelTabsonly while the right panel is openRightPanelTabschanges tab-bar padding for inline desktop mode when layout controls are present, replacing thenative-controlsinset plus six rem with just thenative-controlsinsetMacroscope summarized b3ceeab.
Implemented by gpt-5.6-sol in T3 Code through the Codex harness.