Skip to content

fix(web): keep right panel controls clickable - #9517

Merged
maria-rcks merged 2 commits into
pingdotgg:mainfrom
maria-rcks:t3code/fix-right-panel-tab-controls
Sep 4, 2026
Merged

fix(web): keep right panel controls clickable#9517
maria-rcks merged 2 commits into
pingdotgg:mainfrom
maria-rcks:t3code/fix-right-panel-tab-controls

Conversation

@maria-rcks

@maria-rcks maria-rcks commented Sep 3, 2026

Copy link
Copy Markdown
Collaborator

The Electron drag region around scrollable right-panel tabs intercepted the header controls, and maximizing the panel hid its restore control with the collapsed chat column. This moves the open-panel controls into the tab bar's no-drag area while keeping the closed-state controls in the chat header, so maximize, restore, terminal, and panel toggles remain reachable. Web typecheck, targeted lint, formatting, and real-app interaction checks pass; the existing component tests are blocked before collection by the repository's current vite-plus/test config error.


Note

Low Risk
UI layout and pointer-event behavior only in the chat workspace header and right panel tab bar; no auth, data, or API changes.

Overview
Moves maximize/restore and panel toggle controls into the inline right panel tab bar when that panel is open, instead of leaving them in the fixed chat header where Electron’s tab-bar drag region could swallow clicks.

rightPanelControlsInPanel now requires the panel to be present and open, so the header shows panelLayoutControls only while the inline panel is closed; open inline panels receive layoutControls on RightPanelTabs inside a [-webkit-app-region:no-drag] cluster. RightPanelTabs tightens title-bar padding when those controls are embedded so window chrome spacing stays correct.

Reviewed by Cursor Bugbot for commit b3ceeab. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Fix right panel controls rendering in 'ChatViewContent' and 'RightPanelTabs'

  • ChatViewContent passes an inline control cluster (maximize and toggle controls) to RightPanelTabs only while the right panel is open
  • The workspace header renders its panel layout controls only when the panel is closed or not present
  • Risk: RightPanelTabs changes tab-bar padding for inline desktop mode when layout controls are present, replacing the native-controls inset plus six rem with just the native-controls inset

Macroscope summarized b3ceeab.

right panel controls remain reachable through maximize, restore, terminal, and panel toggles

Implemented by gpt-5.6-sol in T3 Code through the Codex harness.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:S 10-29 changed lines (additions + deletions). labels Sep 3, 2026

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 12ccca5. Configure here.

Comment thread apps/web/src/components/ChatView.tsx
@macroscopeapp

macroscopeapp Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at b3ceeab

Macroscope's review found this PR approvable — This is a contained UI bug fix that moves existing right-panel controls into an Electron no-drag region when the panel is open and preserves closed-state header controls. Its runtime impact is limited to control reachability and title-bar spacing, with no data, API, security, or product-default changes.

You can add or adjust custom eligibility rules. Learn more.

@maria-rcks
maria-rcks merged commit 0a0b6be into pingdotgg:main Sep 4, 2026
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S 10-29 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant