Skip to content

*: bump client-go to master - #70301

Merged
ti-chi-bot[bot] merged 1 commit into
pingcap:masterfrom
wfxr:bump-up-client-go-master
Aug 3, 2026
Merged

ti-chi-bot[bot] merged 1 commit into
pingcap:masterfrom
wfxr:bump-up-client-go-master

Conversation

@wfxr

@wfxr wfxr commented Aug 3, 2026 •

Copy link
Copy Markdown
Member

What problem does this PR solve?

Issue Number: ref #69335

Problem Summary:

TiDB was pinned to an older client-go master commit. The latest client-go master commit updates its Go toolchain requirement to Go 1.25.12, matching TiDB's current Go version.

What changed and how does it work?

  • Bump github.com/tikv/client-go/v2 from 61ecd7c11416 to 341d4692ec57 (v2.0.8-0.20260803074519-341d4692ec57).
  • Regenerate the Go module checksums and Bazel dependency metadata.
  • The upstream delta is *: upgrade Go to 1.25.12 tikv/client-go#2036 and contains no client-go source or API changes.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Commands:

go mod verify
make tidy
make check-bazel-prepare
./tools/check/failpoint-go-test.sh pkg/store/driver -run '^TestSetDefaultAndOptions$' -count=1
make lint

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Summary by CodeRabbit

  • Chores
    • Updated the TiKV client dependency to a newer version.
    • Refreshed the associated dependency checksum for consistency.

Update client-go to 341d4692ec57 and regenerate the Bazel dependency metadata.

Signed-off-by: Wenxuan Zhang <wenxuangm@gmail.com>
@ti-chi-bot ti-chi-bot Bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 3, 2026
@coderabbitai

coderabbitai Bot commented Aug 3, 2026 •

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

Changes

TikV client dependency

Layer / File(s) Summary
Synchronize dependency declarations
go.mod, DEPS.bzl
Updated github.com/tikv/client-go/v2 to the August 2026 pseudo-version. Updated the Bazel checksum.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: lcwangchao, joechenrh, bb7133

Poem

A rabbit checks the version line,
And finds the checksum neat and fine.
Go hops forward, Bazel too,
Both now point to code anew.
Nibble, sync, and merge with cheer!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly identifies the main change: updating the client-go dependency to master.
Description check ✅ Passed The description includes the issue reference, problem, implementation details, tests, side effects, documentation impact, and release note.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ti-chi-bot ti-chi-bot Bot added do-not-merge/needs-linked-issue needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. and removed do-not-merge/needs-linked-issue labels Aug 3, 2026
@codecov

codecov Bot commented Aug 3, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.6072%. Comparing base (02f5e23) to head (73a0b4c).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #70301        +/-   ##
================================================
- Coverage   76.3266%   73.6072%   -2.7195%     
================================================
  Files          2041       2077        +36     
  Lines        559042     582519     +23477     
================================================
+ Hits         426698     428776      +2078     
- Misses       131444     153275     +21831     
+ Partials        900        468       -432     
Flag Coverage Δ
integration 40.9201% <ø> (+1.2498%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 59.8807% <ø> (ø)
parser ∅ <ø> (∅)
br 46.6190% <ø> (-16.0910%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ti-chi-bot ti-chi-bot Bot added the approved label Aug 3, 2026
@coderabbitai coderabbitai Bot mentioned this pull request Aug 3, 2026
1 of 13 tasks
@ti-chi-bot ti-chi-bot Bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Aug 3, 2026
@ti-chi-bot

ti-chi-bot Bot commented Aug 3, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfzjywxk, ekexium

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 3, 2026
@ti-chi-bot

ti-chi-bot Bot commented Aug 3, 2026

Copy link
Copy Markdown

[LGTM Timeline notifier]

Timeline:

  • 2026-08-03 08:45:11.54318244 +0000 UTC m=+2431297.579277486: ☑️ agreed by cfzjywxk.
  • 2026-08-03 08:49:01.30451278 +0000 UTC m=+2431527.340607846: ☑️ agreed by ekexium.

@wfxr

wfxr commented Aug 3, 2026

Copy link
Copy Markdown
Member Author

/retest

1 similar comment
@wfxr

wfxr commented Aug 3, 2026

Copy link
Copy Markdown
Member Author

/retest

@ti-chi-bot
ti-chi-bot Bot merged commit efe6e69 into pingcap:master Aug 3, 2026
34 checks passed
@ti-chi-bot

Copy link
Copy Markdown
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #70312.
But this PR has conflicts, please resolve them!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants