Repository navigation
build: upgrade vulnerable dependencies - #70243
ti-chi-bot[bot] merged 8 commits into
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughThe PR refreshes Go and Bazel dependency versions, updates Bazel repository generation settings, and applies targeted compatibility changes for etcd tracing, PromQL parsing, LFU randomness, and GCS error handling. ChangesDependency refresh and compatibility updates
Estimated code review effort: 4 (Complex) | ~45 minutes Possibly related PRs
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-8.5 #70243 +/- ##
================================================
Coverage ? 55.7588%
================================================
Files ? 1852
Lines ? 667014
Branches ? 0
================================================
Hits ? 371919
Misses ? 267476
Partials ? 27619
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
4b1ba25 to
17871e1
Compare
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
DEPS.bzl (1)
5580-5655: 🗄️ Data Integrity & Integration | 🟠 Major | 🏗️ Heavy liftFix the server upgrade patch so it applies and update the stale etcd modules.
DEPS.bzlandgo.modare aligned, butbuild/patches/io_etcd_go_etcd_server v3.patchdoes not apply togo.etcd.io/etcd/server/v3@v3.5.15: withpatch_args = ["-p1"], the-a/etcdserver/api/v3rpc/grpc.gohunk fails to find the source file. Since Bazel can ignore a failed patch, this can silently leave OpenTelemetry instrumentation enabled by default. Also drop the remainingetcd/etcdutl/v3andgo.etcd.io/gofailpins fromDEPS.bzl/go.modif they are no longer used, becausego.etcd.io/etcd/tests/v3remains only ingo.mod.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@DEPS.bzl` around lines 5580 - 5655, Update the etcd server upgrade patch so its grpc.go hunk matches the v3.5.15 source and applies successfully with the existing -p1 configuration, preserving the intended default-disabled OpenTelemetry instrumentation. Remove the unused io_etcd_go_etcd_etcdutl_v3 and io_etcd_go_gofail dependency pins from DEPS.bzl and go.mod, while retaining the etcd tests module entry in go.mod.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@DEPS.bzl`:
- Around line 5580-5655: Update the etcd server upgrade patch so its grpc.go
hunk matches the v3.5.15 source and applies successfully with the existing -p1
configuration, preserving the intended default-disabled OpenTelemetry
instrumentation. Remove the unused io_etcd_go_etcd_etcdutl_v3 and
io_etcd_go_gofail dependency pins from DEPS.bzl and go.mod, while retaining the
etcd tests module entry in go.mod.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro Plus
Run ID: c8b555e9-0b02-4205-af9d-baa1dc549319
⛔ Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum
📒 Files selected for processing (3)
DEPS.bzlbuild/patches/io_etcd_go_etcd_server_v3.patchgo.mod
|
/retest |
1 similar comment
|
/retest |
|
/retest |
|
/retest |
1 similar comment
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AilinKid, D3Hunter, djshow832 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Remove the temporary cloud storage v1.39.1 replacement. The newer GCS client validates service-account fields when the client is created, so populate the required fields in the no-HTTP-client test fixture.
|
/retest |
|
@YangKeao: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/retest |
What problem does this PR solve?
Issue Number: close #70242
Problem Summary:
What changed and how does it work?
Upgrade the dependencies to the newer version.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.
Summary by CodeRabbit
Bug Fixes
Maintenance
Tests