Skip to content

dep: update pd client for batched runtime trace regions - #70310

Merged
ti-chi-bot[bot] merged 4 commits into
release-8.5from
agent/tidb-developer/pin-87-update-pd-client
Aug 4, 2026
Merged

ti-chi-bot[bot] merged 4 commits into
release-8.5from
agent/tidb-developer/pin-87-update-pd-client

Conversation

@YangKeao

@YangKeao YangKeao commented Aug 3, 2026 •

Copy link
Copy Markdown
Member

What problem does this PR solve?

Issue Number: ref #69743

Problem Summary:

TiDB release-8.5 uses a PD client that can emit invalid nested Go runtime trace regions for batched TSO requests. tikv/pd#11095 backports the batch-level runtime trace fix to PD release-8.5.

What changed and how does it work?

Update the official github.com/tikv/pd/client dependency to the revision merged by tikv/pd#11095:

github.com/tikv/pd/client v0.0.0-20260804033407-85a975a5ca78

The temporary github.com/YangKeao/pd/client fork replacement has been removed. The Go module graph and DEPS.bzl are synchronized with the dependency versions required by the official PD client revision.

Check List

Tests:

  • git diff --check
  • go mod tidy -diff
  • go mod verify
  • go test ./pkg/store/driver ./pkg/kv -run '^$'
  • CI

Side effects:

  • Performance regression
  • Breaking backward compatibility

Release note

None

Summary by CodeRabbit

  • Chores
    • Updated internal third-party components and verification data to keep supporting libraries current.
    • No user-facing features or behavior changes are included in this update.

Signed-off-by: Yang Keao <yangkeao@chunibyo.icu>
@ti-chi-bot

ti-chi-bot Bot commented Aug 3, 2026

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot Bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/cherry-pick-not-approved labels Aug 3, 2026
@coderabbitai

coderabbitai Bot commented Aug 3, 2026 •

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: d95abb71-77a6-44ae-90ed-0a62c2918301

📥 Commits

Reviewing files that changed from the base of the PR and between c26e3cd and 809bb79.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (2)
  • DEPS.bzl
  • go.mod
🚧 Files skipped from review as they are similar to previous changes (1)
  • DEPS.bzl

📝 Walkthrough

Walkthrough

The PR updates the TikV PD client version in go.mod and refreshes dependency versions and checksums in DEPS.bzl for networking, telemetry, protobuf, Google APIs, and related Go packages.

Changes

Go Dependency Refresh

Layer / File(s) Summary
Go module version alignment
go.mod
The TikV PD client is updated to a newer pseudo-version.
Bazel dependency pin alignment
DEPS.bzl
Pinned versions and checksums are updated for xDS, Envoy, validation, JOSE, OpenTelemetry, TikV PD, Google APIs, gRPC, protobuf, golang.org/x/*, and Gonum dependencies.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

Suggested labels: needs-cherry-pick-release-8.5

Suggested reviewers: bb7133, ti-chi-bot

Poem

A rabbit checks each version trail,
New checksums mark the update well.
PD and protobuf hop in line,
Go pins rest neat and bright and fine.
The build files thump a steady beat.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the PD client update and its purpose of supporting batched runtime trace regions.
Description check ✅ Passed The description covers the issue, problem, changes, tests, side effects, and release note; the Documentation section is omitted.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch agent/tidb-developer/pin-87-update-pd-client

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.12.2)

Error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions
The command is terminated due to an error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ti-chi-bot ti-chi-bot Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 3, 2026
@YangKeao YangKeao changed the title PIN-87: test PD client backport for batched trace regions dep: update pd client for batched runtime trace regions Aug 3, 2026
Comment thread go.mod Outdated
@YangKeao
YangKeao marked this pull request as ready for review August 3, 2026 10:50
@ti-chi-bot ti-chi-bot Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 3, 2026
@YangKeao

YangKeao commented Aug 3, 2026

Copy link
Copy Markdown
Member Author

/hold

@ti-chi-bot ti-chi-bot Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 3, 2026
@codecov

codecov Bot commented Aug 3, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (release-8.5@7c49d96). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-8.5     #70310   +/-   ##
================================================
  Coverage               ?   55.2484%           
================================================
  Files                  ?       1852           
  Lines                  ?     667103           
  Branches               ?          0           
================================================
  Hits                   ?     368564           
  Misses                 ?     271119           
  Partials               ?      27420           
Flag Coverage Δ
integration 38.2804% <ø> (?)
unit 65.2575% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 55.3108% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 54.8263% <0.0000%> (?)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ti-chi-bot ti-chi-bot Bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Aug 3, 2026
Signed-off-by: Yang Keao <yangkeao@chunibyo.icu>
@ti-chi-bot ti-chi-bot Bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 4, 2026
Signed-off-by: Yang Keao <yangkeao@chunibyo.icu>
@YangKeao

YangKeao commented Aug 4, 2026

Copy link
Copy Markdown
Member Author

/unhold

@ti-chi-bot ti-chi-bot Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 4, 2026
@YangKeao
YangKeao requested review from D3Hunter and bb7133 August 4, 2026 04:03
@ti-chi-bot ti-chi-bot Bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 4, 2026
@ti-chi-bot

ti-chi-bot Bot commented Aug 4, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: D3Hunter, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added the lgtm label Aug 4, 2026
@ti-chi-bot ti-chi-bot Bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Aug 4, 2026
@ti-chi-bot

ti-chi-bot Bot commented Aug 4, 2026

Copy link
Copy Markdown

[LGTM Timeline notifier]

Timeline:

  • 2026-08-04 04:07:01.936838939 +0000 UTC m=+2501007.972933995: ☑️ agreed by rleungx.
  • 2026-08-04 04:07:53.436511514 +0000 UTC m=+2501059.472606570: ☑️ agreed by D3Hunter.

@YangKeao

YangKeao commented Aug 4, 2026

Copy link
Copy Markdown
Member Author

/retest

1 similar comment
@YangKeao

YangKeao commented Aug 4, 2026

Copy link
Copy Markdown
Member Author

/retest

@ti-chi-bot ti-chi-bot Bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 4, 2026
@ti-chi-bot
ti-chi-bot Bot merged commit 9eafbb2 into release-8.5 Aug 4, 2026
19 checks passed
@ti-chi-bot
ti-chi-bot Bot deleted the agent/tidb-developer/pin-87-update-pd-client branch August 4, 2026 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants