Repository navigation
dep: update pd client for batched runtime trace regions - #70310
Conversation
Signed-off-by: Yang Keao <yangkeao@chunibyo.icu>
|
Skipping CI for Draft Pull Request. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe PR updates the TikV PD client version in ChangesGo Dependency Refresh
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Suggested labels: Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 golangci-lint (2.12.2)Error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
/hold |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-8.5 #70310 +/- ##
================================================
Coverage ? 55.2484%
================================================
Files ? 1852
Lines ? 667103
Branches ? 0
================================================
Hits ? 368564
Misses ? 271119
Partials ? 27420
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Signed-off-by: Yang Keao <yangkeao@chunibyo.icu>
Signed-off-by: Yang Keao <yangkeao@chunibyo.icu>
|
/unhold |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: D3Hunter, rleungx The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
1 similar comment
|
/retest |
What problem does this PR solve?
Issue Number: ref #69743
Problem Summary:
TiDB
release-8.5uses a PD client that can emit invalid nested Go runtime trace regions for batched TSO requests. tikv/pd#11095 backports the batch-level runtime trace fix to PDrelease-8.5.What changed and how does it work?
Update the official
github.com/tikv/pd/clientdependency to the revision merged by tikv/pd#11095:The temporary
github.com/YangKeao/pd/clientfork replacement has been removed. The Go module graph andDEPS.bzlare synchronized with the dependency versions required by the official PD client revision.Check List
Tests:
git diff --checkgo mod tidy -diffgo mod verifygo test ./pkg/store/driver ./pkg/kv -run '^$'Side effects:
Release note
Summary by CodeRabbit