Repository navigation
build: resolve Bazel Go deps through GOPROXY (#69503) - #69843
ti-chi-bot[bot] merged 1 commit into
Conversation
|
Hi @dillon-zheng. Thanks for your PR. I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (6)
💤 Files with no reviewable changes (2)
📝 WalkthroughWalkthroughThe Bazel mirror tool no longer uploads or reuses GCS mirror artifacts. It generates ChangesMirror generation
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant Makefile
participant MirrorBinary
participant GoModuleDownload
Makefile->>MirrorBinary: invoke Bazel mirror target
MirrorBinary->>GoModuleDownload: resolve module metadata
GoModuleDownload-->>MirrorBinary: return sum, version, and replacement data
MirrorBinary-->>Makefile: write DEPS.bzl entries
Possibly related PRs
Suggested labels: Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 golangci-lint (2.12.2)level=error msg="Running error: context loading failed: failed to load packages: failed to load packages: failed to load with go/packages: context deadline exceeded" Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
/ok-to-test |
|
@wuhuizuo: adding LGTM is restricted to approvers and reviewers in OWNERS files. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-nextgen-202603 #69843 +/- ##
===========================================================
Coverage ? 76.1578%
===========================================================
Files ? 1936
Lines ? 540873
Branches ? 0
===========================================================
Hits ? 411917
Misses ? 128956
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cfzjywxk, D3Hunter, wuhuizuo, YangKeao The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
6bd32d0
into
pingcap:release-nextgen-202603
This is a manual cherry-pick of #69503 to release-nextgen-202603.
The bot-created PR #69841 left conflict markers in DEPS.bzl, so this branch resolves the small cmd/mirror conflict and regenerates DEPS.bzl with the updated generator instead of hand-resolving thousands of DEPS.bzl hunks.
Validation:
Issue Number: close #69513
Release note:
Summary by CodeRabbit
New Features
Bug Fixes
Chores
GOPROXYand regenerate dependencies withmake bazel_mirror.