Repository navigation
build: resolve Bazel Go deps through GOPROXY - #69844
ti-chi-bot[bot] merged 1 commit into
Conversation
|
Hi @dillon-zheng. Thanks for your PR. I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
📝 WalkthroughWalkthroughThe mirror tool now relies on GOPROXY metadata to generate ChangesGOPROXY mirror refactor
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Suggested labels: Suggested reviewers: Sequence Diagram(s)sequenceDiagram
participant Makefile
participant mirror
participant GOPROXY
participant DEPSbzl
Makefile->>mirror: Run mirror generation
mirror->>GOPROXY: List and download modules
GOPROXY-->>mirror: Return module metadata
mirror->>DEPSbzl: Generate repository rules from sum and version
DEPSbzl-->>Makefile: Write redirected output
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
/ok-to-test |
|
@wuhuizuo: adding LGTM is restricted to approvers and reviewers in OWNERS files. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-8.5 #69844 +/- ##
================================================
Coverage ? 55.1436%
================================================
Files ? 1849
Lines ? 666253
Branches ? 0
================================================
Hits ? 367396
Misses ? 271449
Partials ? 27408
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: D3Hunter, wuhuizuo, YangKeao The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Manual backport of #69503 to release-8.5.
This keeps the release-8.5-specific Bazel dependency generation behavior, regenerates DEPS.bzl with cmd/mirror, and removes the old pingcapmirror/static URL flow.
Validation:
Issue Number: close #69513
Release note:
Summary by CodeRabbit
New Features
GOPROXY.Deprecations
Improvements