Skip to content

fix: allow Codex review batches outside Git repositories #896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Mgldvd wants to merge 2 commits into from
Closed

fix: allow Codex review batches outside Git repositories #896

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
733580b
fix: run Codex review batches outside Git repositories
Mgldvd Oct 26, 2026
982b341
style: format touched runner imports and assertions
Mgldvd Oct 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion desloppify/app/commands/runner/codex_batch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,9 @@
resolve_retry_config,
run_batch_attempt,
)
from desloppify.app.commands.review.runner_process_impl.io import extract_payload_from_log
from desloppify.app.commands.review.runner_process_impl.io import (
extract_payload_from_log,
)
from desloppify.app.commands.review.runner_process_impl.types import (
CodexBatchRunnerDeps,
FollowupScanDeps,
Expand Down Expand Up @@ -95,6 +97,8 @@ def codex_batch_command(*, prompt: str, repo_root: Path, output_file: Path) -> l
*prefix,
"exec",
"--ephemeral",
# Scans also support source archives and directories without Git metadata.
"--skip-git-repo-check",
"-C",
str(repo_root),
"-s",
Expand Down
5 changes: 3 additions & 2 deletions desloppify/tests/commands/test_runner_modules_direct.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,8 @@ def test_codex_batch_command_uses_sanitized_reasoning_effort(monkeypatch, tmp_pa
assert any(c.endswith("codex") or "codex" in c for c in command[:3])
assert "exec" in command
assert "--ephemeral" in command
assert f'model_reasoning_effort="high"' in command
assert "--skip-git-repo-check" in command
assert 'model_reasoning_effort="high"' in command
assert str(tmp_path) in command

monkeypatch.setenv("DESLOPPIFY_CODEX_REASONING_EFFORT", "invalid")
Expand All @@ -183,7 +184,7 @@ def test_codex_batch_command_uses_sanitized_reasoning_effort(monkeypatch, tmp_pa
repo_root=tmp_path,
output_file=tmp_path / "out.json",
)
assert f'model_reasoning_effort="low"' in command
assert 'model_reasoning_effort="low"' in command


def test_codex_batch_command_uses_sandbox_env_override(monkeypatch, tmp_path: Path) -> None:
Expand Down