Skip to content

fix: allow Codex review batches outside Git repositories - #896

Closed
Mgldvd wants to merge 2 commits into
peteromallet:mainfrom
Mgldvd:fix/codex-non-git
Closed

Mgldvd wants to merge 2 commits into
peteromallet:mainfrom
Mgldvd:fix/codex-non-git

Conversation

@Mgldvd

@Mgldvd Mgldvd commented Oct 26, 2026

Copy link
Copy Markdown

Review batches currently fail for a source directory without Git metadata. desloppify review --run-batches --runner codex exits before reviewing anything with: “Not inside a trusted directory and --skip-git-repo-check was not specified.”

Pass --skip-git-repo-check to the Codex batch command so the already selected scan path works for extracted archives and ordinary source folders. The existing command-builder regression test now checks the option. Formatting fixes in the two touched files remove three existing Ruff findings.

Validation: 12 runner tests pass; Ruff and git diff --check pass. Reproduced the failure against a real non-Git project and verified the same Codex command runs successfully with the option; the project's review batches now complete using a temporary wrapper that inserts this flag.

Copilot AI balanced review requested due to automatic review settings October 26, 2026 19:57

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The narrow command change addresses the reported failure, includes regression coverage, and has no identified blocking issues.

No open issues 🎉

What changed in this PR

This PR allows Codex review batches to run on source archives and ordinary directories without Git metadata.

Changes:

  • Adds --skip-git-repo-check to the Codex batch command.
  • Extends the command-builder regression test to check the flag.
  • Cleans up import formatting and unnecessary f-string prefixes.
File Description
desloppify/​tests/​commands/​test_runner_modules_direct.py Checks the new flag and removes unnecessary f-string prefixes.
desloppify/​app/​commands/​runner/​codex_batch.py Adds the flag for non-Git directories and reformats an import.

Review effort: Balanced

github-actions Bot added a commit to citizenadam/desloppify that referenced this pull request Oct 26, 2026
@Mgldvd Mgldvd closed this Oct 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants