Repository navigation
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The narrow command change addresses the reported failure, includes regression coverage, and has no identified blocking issues.
No open issues 🎉
What changed in this PR
This PR allows Codex review batches to run on source archives and ordinary directories without Git metadata.
Changes:
- Adds
--skip-git-repo-checkto the Codex batch command. - Extends the command-builder regression test to check the flag.
- Cleans up import formatting and unnecessary f-string prefixes.
| File | Description |
|---|---|
desloppify/tests/commands/test_runner_modules_direct.py |
Checks the new flag and removes unnecessary f-string prefixes. |
desloppify/app/commands/runner/codex_batch.py |
Adds the flag for non-Git directories and reformats an import. |
Review effort: Balanced
github-actions Bot
added a commit
to citizenadam/desloppify
that referenced
this pull request
Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review batches currently fail for a source directory without Git metadata.
desloppify review --run-batches --runner codexexits before reviewing anything with: “Not inside a trusted directory and --skip-git-repo-check was not specified.”Pass
--skip-git-repo-checkto the Codex batch command so the already selected scan path works for extracted archives and ordinary source folders. The existing command-builder regression test now checks the option. Formatting fixes in the two touched files remove three existing Ruff findings.Validation: 12 runner tests pass; Ruff and
git diff --checkpass. Reproduced the failure against a real non-Git project and verified the same Codex command runs successfully with the option; the project's review batches now complete using a temporary wrapper that inserts this flag.