fix: recognize custom expectations provided by methods class reflection extensions

src/Type/Pest/HigherOrderExpectationTypeExtension.php

@@ -300,18 +300,6 @@ private function isKnownExpectationMethod(string $methodName): bool
 
         $classReflection = $this->reflectionProvider->getClass(Expectation::class);
 
-        if ($classReflection->hasNativeMethod($methodName)) {
-            return true;
-        }
-
-        foreach ($classReflection->getResolvedMixinTypes() as $mixinType) {
-            foreach ($mixinType->getObjectClassReflections() as $mixinClassReflection) {
-                if ($mixinClassReflection->hasNativeMethod($methodName)) {
-                    return true;
-                }
-            }
-        }
-
-        return false;
+        return $classReflection->hasMethod($methodName);
     }
 }

tests/Rules/CustomExpectationMethodCallTest.php

@@ -0,0 +1,21 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Tests\Rules;
+
+use PHPStan\Rules\Methods\CallMethodsRule;
+use Tests\RuleTestCase;
+
+beforeAll(function (): void {
+    RuleTestCase::$additionalConfigFiles = [
+        __DIR__.'/custom-expectations.neon',
+    ];
+    RuleTestCase::$rule = RuleTestCase::resolveRule(CallMethodsRule::class);
+});
+
+test('custom expectations from a methods class reflection extension are not higher order method calls', function (): void {
+    $this->analyse([
+        __DIR__.'/data/custom-expectation-method-call.php',
+    ], []);
+});

tests/Rules/Fixtures/CustomExpectations.php

@@ -0,0 +1,15 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Tests\Rules\Fixtures;
+
+use Pest\Expectation;
+
+interface CustomExpectations
+{
+    /**
+     * @return Expectation<mixed>
+     */
+    public function toBeCustom(): Expectation;
+}

tests/Rules/Fixtures/CustomExpectationsExtension.php

@@ -0,0 +1,32 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Tests\Rules\Fixtures;
+
+use Pest\Expectation;
+use PHPStan\Reflection\ClassReflection;
+use PHPStan\Reflection\MethodReflection;
+use PHPStan\Reflection\MethodsClassReflectionExtension;
+use PHPStan\Reflection\ReflectionProvider;
+
+final readonly class CustomExpectationsExtension implements MethodsClassReflectionExtension
+{
+    public function __construct(private ReflectionProvider $reflectionProvider) {}
+
+    public function hasMethod(ClassReflection $classReflection, string $methodName): bool
+    {
+        return $classReflection->getName() === Expectation::class
+            && $this->customExpectations()->hasNativeMethod($methodName);
+    }
+
+    public function getMethod(ClassReflection $classReflection, string $methodName): MethodReflection
+    {
+        return $this->customExpectations()->getNativeMethod($methodName);
+    }
+
+    private function customExpectations(): ClassReflection
+    {
+        return $this->reflectionProvider->getClass(CustomExpectations::class);
+    }
+}

tests/Rules/custom-expectations.neon

@@ -0,0 +1,8 @@
+includes:
+    - ../extension.neon
+
+services:
+    -
+        class: Tests\Rules\Fixtures\CustomExpectationsExtension
+        tags:
+            - phpstan.broker.methodsClassReflectionExtension

tests/Rules/data/custom-expectation-method-call.php

@@ -0,0 +1,13 @@
+<?php
+
+declare(strict_types=1);
+
+use Tests\Type\Fixtures\Post;
+
+it('calls a custom expectation provided by a methods class reflection extension', function (): void {
+    expect(Post::class)->toBeCustom();
+
+    expect(new Post)->toBeCustom();
+
+    expect('Hello')->toBeCustom();
+});