Repository navigation
fix: recognize custom expectations provided by methods class reflection extensions - #24
Merged
MrPunyapal merged 1 commit intoOct 28, 2026
Conversation
Member
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #17,
isKnownExpectationMethod()only recognizes the native and@mixinmethods ofPest\Expectation. A custom expectation that a project declares to PHPStan through aMethodsClassReflectionExtension(the usual way to typeexpect()->extend()calls) is therefore treated as a higher-order method call on the expectation value.When that value is a class-string, the call crashes the analysis:
hasMethod()on a class-string is notno(), soresolveMethodReturnType()callsgetMethod()on aStringType, which throws something other thanMissingMethodFromReflectionException.This PR uses
ClassReflection::hasMethod()instead. It covers native methods,@mixinmethods and methods provided by extensions, so the existing higher-order behavior from #17 is unchanged.The new
CustomExpectationMethodCallTestregisters such an extension and fails with the internal error above without the fix.composer lint,composer test:typesand the whole suite pass with it.